Commit ad3703ac authored by Georgi Djakov's avatar Georgi Djakov

interconnect: qcom: Use the new common helper for node removal

There is a new helper function for removing all nodes. Let's use it instead
of duplicating the code.
Reviewed-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: default avatarGeorgi Djakov <georgi.djakov@linaro.org>
parent 3cce2c6f
...@@ -652,7 +652,7 @@ static int msm8974_icc_probe(struct platform_device *pdev) ...@@ -652,7 +652,7 @@ static int msm8974_icc_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev; struct device *dev = &pdev->dev;
struct icc_onecell_data *data; struct icc_onecell_data *data;
struct icc_provider *provider; struct icc_provider *provider;
struct icc_node *node, *tmp; struct icc_node *node;
size_t num_nodes, i; size_t num_nodes, i;
int ret; int ret;
...@@ -732,10 +732,7 @@ static int msm8974_icc_probe(struct platform_device *pdev) ...@@ -732,10 +732,7 @@ static int msm8974_icc_probe(struct platform_device *pdev)
return 0; return 0;
err_del_icc: err_del_icc:
list_for_each_entry_safe(node, tmp, &provider->nodes, node_list) { icc_nodes_remove(provider);
icc_node_del(node);
icc_node_destroy(node->id);
}
icc_provider_del(provider); icc_provider_del(provider);
err_disable_clks: err_disable_clks:
...@@ -747,16 +744,10 @@ static int msm8974_icc_probe(struct platform_device *pdev) ...@@ -747,16 +744,10 @@ static int msm8974_icc_probe(struct platform_device *pdev)
static int msm8974_icc_remove(struct platform_device *pdev) static int msm8974_icc_remove(struct platform_device *pdev)
{ {
struct msm8974_icc_provider *qp = platform_get_drvdata(pdev); struct msm8974_icc_provider *qp = platform_get_drvdata(pdev);
struct icc_provider *provider = &qp->provider;
struct icc_node *n, *tmp;
list_for_each_entry_safe(n, tmp, &provider->nodes, node_list) { icc_nodes_remove(&qp->provider);
icc_node_del(n);
icc_node_destroy(n->id);
}
clk_bulk_disable_unprepare(qp->num_clks, qp->bus_clks); clk_bulk_disable_unprepare(qp->num_clks, qp->bus_clks);
return icc_provider_del(&qp->provider);
return icc_provider_del(provider);
} }
static const struct of_device_id msm8974_noc_of_match[] = { static const struct of_device_id msm8974_noc_of_match[] = {
......
...@@ -414,7 +414,7 @@ static int qnoc_probe(struct platform_device *pdev) ...@@ -414,7 +414,7 @@ static int qnoc_probe(struct platform_device *pdev)
struct icc_provider *provider; struct icc_provider *provider;
struct qcom_icc_node **qnodes; struct qcom_icc_node **qnodes;
struct qcom_icc_provider *qp; struct qcom_icc_provider *qp;
struct icc_node *node, *tmp; struct icc_node *node;
size_t num_nodes, i; size_t num_nodes, i;
int ret; int ret;
...@@ -494,10 +494,7 @@ static int qnoc_probe(struct platform_device *pdev) ...@@ -494,10 +494,7 @@ static int qnoc_probe(struct platform_device *pdev)
return 0; return 0;
err: err:
list_for_each_entry_safe(node, tmp, &provider->nodes, node_list) { icc_nodes_remove(provider);
icc_node_del(node);
icc_node_destroy(node->id);
}
clk_bulk_disable_unprepare(qp->num_clks, qp->bus_clks); clk_bulk_disable_unprepare(qp->num_clks, qp->bus_clks);
icc_provider_del(provider); icc_provider_del(provider);
...@@ -507,16 +504,10 @@ static int qnoc_probe(struct platform_device *pdev) ...@@ -507,16 +504,10 @@ static int qnoc_probe(struct platform_device *pdev)
static int qnoc_remove(struct platform_device *pdev) static int qnoc_remove(struct platform_device *pdev)
{ {
struct qcom_icc_provider *qp = platform_get_drvdata(pdev); struct qcom_icc_provider *qp = platform_get_drvdata(pdev);
struct icc_provider *provider = &qp->provider;
struct icc_node *n, *tmp;
list_for_each_entry_safe(n, tmp, &provider->nodes, node_list) { icc_nodes_remove(&qp->provider);
icc_node_del(n);
icc_node_destroy(n->id);
}
clk_bulk_disable_unprepare(qp->num_clks, qp->bus_clks); clk_bulk_disable_unprepare(qp->num_clks, qp->bus_clks);
return icc_provider_del(&qp->provider);
return icc_provider_del(provider);
} }
static const struct of_device_id qcs404_noc_of_match[] = { static const struct of_device_id qcs404_noc_of_match[] = {
......
...@@ -855,11 +855,7 @@ static int qnoc_probe(struct platform_device *pdev) ...@@ -855,11 +855,7 @@ static int qnoc_probe(struct platform_device *pdev)
return ret; return ret;
err: err:
list_for_each_entry(node, &provider->nodes, node_list) { icc_nodes_remove(provider);
icc_node_del(node);
icc_node_destroy(node->id);
}
icc_provider_del(provider); icc_provider_del(provider);
return ret; return ret;
} }
...@@ -867,15 +863,9 @@ static int qnoc_probe(struct platform_device *pdev) ...@@ -867,15 +863,9 @@ static int qnoc_probe(struct platform_device *pdev)
static int qnoc_remove(struct platform_device *pdev) static int qnoc_remove(struct platform_device *pdev)
{ {
struct qcom_icc_provider *qp = platform_get_drvdata(pdev); struct qcom_icc_provider *qp = platform_get_drvdata(pdev);
struct icc_provider *provider = &qp->provider;
struct icc_node *n, *tmp;
list_for_each_entry_safe(n, tmp, &provider->nodes, node_list) {
icc_node_del(n);
icc_node_destroy(n->id);
}
return icc_provider_del(provider); icc_nodes_remove(&qp->provider);
return icc_provider_del(&qp->provider);
} }
static const struct of_device_id qnoc_of_match[] = { static const struct of_device_id qnoc_of_match[] = {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment