Commit adc18ba9 authored by Quentin Schulz's avatar Quentin Schulz Committed by Jonathan Cameron

iio: adc: axp20x_adc: remove !! in favor of ternary condition

!!'s behaviour isn't that obvious and sparse complained about it, so
let's replace it with a ternary condition.
Signed-off-by: default avatarQuentin Schulz <quentin.schulz@bootlin.com>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 4c73b809
...@@ -445,7 +445,7 @@ static int axp20x_adc_offset_voltage(struct iio_dev *indio_dev, int channel, ...@@ -445,7 +445,7 @@ static int axp20x_adc_offset_voltage(struct iio_dev *indio_dev, int channel,
return -EINVAL; return -EINVAL;
} }
*val = !!(*val) * 700000; *val = *val ? 700000 : 0;
return IIO_VAL_INT; return IIO_VAL_INT;
} }
...@@ -542,15 +542,17 @@ static int axp20x_write_raw(struct iio_dev *indio_dev, ...@@ -542,15 +542,17 @@ static int axp20x_write_raw(struct iio_dev *indio_dev,
if (val != 0 && val != 700000) if (val != 0 && val != 700000)
return -EINVAL; return -EINVAL;
val = val ? 1 : 0;
switch (chan->channel) { switch (chan->channel) {
case AXP20X_GPIO0_V: case AXP20X_GPIO0_V:
reg = AXP20X_GPIO10_IN_RANGE_GPIO0; reg = AXP20X_GPIO10_IN_RANGE_GPIO0;
regval = AXP20X_GPIO10_IN_RANGE_GPIO0_VAL(!!val); regval = AXP20X_GPIO10_IN_RANGE_GPIO0_VAL(val);
break; break;
case AXP20X_GPIO1_V: case AXP20X_GPIO1_V:
reg = AXP20X_GPIO10_IN_RANGE_GPIO1; reg = AXP20X_GPIO10_IN_RANGE_GPIO1;
regval = AXP20X_GPIO10_IN_RANGE_GPIO1_VAL(!!val); regval = AXP20X_GPIO10_IN_RANGE_GPIO1_VAL(val);
break; break;
default: default:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment