Commit add8287e authored by Artem Bityutskiy's avatar Artem Bityutskiy

UBI: fix documentation and improve readability

The "max" parameter of 'find_wl_entry()' was documented incorrectly and
it actually means the maximum possible difference from the smallest erase
counter. Rename it to "diff" instead, and amend the documentation.
Reported-by: default avatarShmulik Ladkani <shmulik.ladkani@gmail.com>
Signed-off-by: default avatarArtem Bityutskiy <artem.bityutskiy@linux.intel.com>
Reviewed-by: default avatarShmulik Ladkani <shmulik.ladkani@gmail.com>
parent a29852be
...@@ -350,18 +350,19 @@ static void prot_queue_add(struct ubi_device *ubi, struct ubi_wl_entry *e) ...@@ -350,18 +350,19 @@ static void prot_queue_add(struct ubi_device *ubi, struct ubi_wl_entry *e)
/** /**
* find_wl_entry - find wear-leveling entry closest to certain erase counter. * find_wl_entry - find wear-leveling entry closest to certain erase counter.
* @root: the RB-tree where to look for * @root: the RB-tree where to look for
* @max: highest possible erase counter * @diff: maximum possible difference from the smallest erase counter
* *
* This function looks for a wear leveling entry with erase counter closest to * This function looks for a wear leveling entry with erase counter closest to
* @max and less than @max. * min + @diff, where min is the smallest erase counter.
*/ */
static struct ubi_wl_entry *find_wl_entry(struct rb_root *root, int max) static struct ubi_wl_entry *find_wl_entry(struct rb_root *root, int diff)
{ {
struct rb_node *p; struct rb_node *p;
struct ubi_wl_entry *e; struct ubi_wl_entry *e;
int max;
e = rb_entry(rb_first(root), struct ubi_wl_entry, u.rb); e = rb_entry(rb_first(root), struct ubi_wl_entry, u.rb);
max += e->ec; max = e->ec + diff;
p = root->rb_node; p = root->rb_node;
while (p) { while (p) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment