Commit ae0f74be authored by Paul Kocialkowski's avatar Paul Kocialkowski Committed by Sebastian Reichel

power: bq24735-charger: Assume not charging when charger is missing

When the charger is missing (disconnected), it is safe to assume that
the charger chip is no charging.

This is especially relevant when a status GPIO is present and the
charger is getting disconnected. bq24735_charger_is_charging will be
triggered due to the interrupt then, it will attempt to read whether it
is charging through i2c, which will fail as the charger is disconnected.

This also fixes that specific issue.
Signed-off-by: default avatarPaul Kocialkowski <contact@paulk.fr>
Signed-off-by: default avatarSebastian Reichel <sre@kernel.org>
parent 1c4593ed
...@@ -201,8 +201,12 @@ static bool bq24735_charger_is_present(struct bq24735 *charger) ...@@ -201,8 +201,12 @@ static bool bq24735_charger_is_present(struct bq24735 *charger)
static int bq24735_charger_is_charging(struct bq24735 *charger) static int bq24735_charger_is_charging(struct bq24735 *charger)
{ {
int ret = bq24735_read_word(charger->client, BQ24735_CHG_OPT); int ret;
if (!bq24735_charger_is_present(charger))
return 0;
ret = bq24735_read_word(charger->client, BQ24735_CHG_OPT);
if (ret < 0) if (ret < 0)
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment