Commit af5ad178 authored by Necip Fazil Yildiran's avatar Necip Fazil Yildiran Committed by Christoph Hellwig

nvme-tcp: fix kconfig dependency warning when !CRYPTO

When NVME_TCP is enabled and CRYPTO is disabled, it results in the
following Kbuild warning:

WARNING: unmet direct dependencies detected for CRYPTO_CRC32C
  Depends on [n]: CRYPTO [=n]
  Selected by [y]:
  - NVME_TCP [=y] && INET [=y] && BLK_DEV_NVME [=y]

The reason is that NVME_TCP selects CRYPTO_CRC32C without depending on or
selecting CRYPTO while CRYPTO_CRC32C is subordinate to CRYPTO.

Honor the kconfig menu hierarchy to remove kconfig dependency warnings.

Fixes: 79fd751d ("nvme: tcp: selects CRYPTO_CRC32C for nvme-tcp")
Signed-off-by: default avatarNecip Fazil Yildiran <fazilyildiran@gmail.com>
Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent ce4cc313
...@@ -73,6 +73,7 @@ config NVME_TCP ...@@ -73,6 +73,7 @@ config NVME_TCP
depends on INET depends on INET
depends on BLK_DEV_NVME depends on BLK_DEV_NVME
select NVME_FABRICS select NVME_FABRICS
select CRYPTO
select CRYPTO_CRC32C select CRYPTO_CRC32C
help help
This provides support for the NVMe over Fabrics protocol using This provides support for the NVMe over Fabrics protocol using
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment