Commit afdd1ebb authored by Necip Fazil Yildiran's avatar Necip Fazil Yildiran Committed by Andy Shevchenko

platform/x86: fix kconfig dependency warning for FUJITSU_LAPTOP

When FUJITSU_LAPTOP is enabled and NEW_LEDS is disabled, it results in the
following Kbuild warning:

WARNING: unmet direct dependencies detected for LEDS_CLASS
  Depends on [n]: NEW_LEDS [=n]
  Selected by [y]:
  - FUJITSU_LAPTOP [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] && ACPI [=y] && INPUT [=y] && BACKLIGHT_CLASS_DEVICE [=y] && (ACPI_VIDEO [=n] || ACPI_VIDEO [=n]=n)

The reason is that FUJITSU_LAPTOP selects LEDS_CLASS without depending on
or selecting NEW_LEDS while LEDS_CLASS is subordinate to NEW_LEDS.

Honor the kconfig menu hierarchy to remove kconfig dependency warnings.
Reported-by: default avatarHans de Goede <hdegoede@redhat.com>
Fixes: d89bcc83 ("platform/x86: fujitsu-laptop: select LEDS_CLASS")
Signed-off-by: default avatarNecip Fazil Yildiran <fazilyildiran@gmail.com>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
parent 8f0c01e6
...@@ -469,6 +469,7 @@ config FUJITSU_LAPTOP ...@@ -469,6 +469,7 @@ config FUJITSU_LAPTOP
depends on BACKLIGHT_CLASS_DEVICE depends on BACKLIGHT_CLASS_DEVICE
depends on ACPI_VIDEO || ACPI_VIDEO = n depends on ACPI_VIDEO || ACPI_VIDEO = n
select INPUT_SPARSEKMAP select INPUT_SPARSEKMAP
select NEW_LEDS
select LEDS_CLASS select LEDS_CLASS
help help
This is a driver for laptops built by Fujitsu: This is a driver for laptops built by Fujitsu:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment