Commit b0255a02 authored by Ondrej Zary's avatar Ondrej Zary Committed by David S. Miller

de2104x: fix power management

At least my 21041 cards come out of suspend with bus mastering disabled so
they did not work after resume(no data transferred).
After adding pci_set_master(), the driver oopsed immediately on resume -
because de_clean_rings() is called on suspend but de_init_rings() call
was missing in resume.

Also disable link (reset SIA) before sleep (de4x5 does this too).
Signed-off-by: default avatarOndrej Zary <linux@rainbow-software.org>
Acked-by: default avatarJeff Garzik <jgarzik@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e0f9c4f3
...@@ -1231,6 +1231,7 @@ static void de_adapter_sleep (struct de_private *de) ...@@ -1231,6 +1231,7 @@ static void de_adapter_sleep (struct de_private *de)
if (de->de21040) if (de->de21040)
return; return;
dw32(CSR13, 0); /* Reset phy */
pci_read_config_dword(de->pdev, PCIPM, &pmctl); pci_read_config_dword(de->pdev, PCIPM, &pmctl);
pmctl |= PM_Sleep; pmctl |= PM_Sleep;
pci_write_config_dword(de->pdev, PCIPM, pmctl); pci_write_config_dword(de->pdev, PCIPM, pmctl);
...@@ -2166,6 +2167,8 @@ static int de_resume (struct pci_dev *pdev) ...@@ -2166,6 +2167,8 @@ static int de_resume (struct pci_dev *pdev)
dev_err(&dev->dev, "pci_enable_device failed in resume\n"); dev_err(&dev->dev, "pci_enable_device failed in resume\n");
goto out; goto out;
} }
pci_set_master(pdev);
de_init_rings(de);
de_init_hw(de); de_init_hw(de);
out_attach: out_attach:
netif_device_attach(dev); netif_device_attach(dev);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment