Commit b06146b6 authored by Gavin Shan's avatar Gavin Shan Committed by Will Deacon

firmware: arm_sdei: Remove while loop in sdei_event_unregister()

This removes the unnecessary while loop in sdei_event_unregister()
because of the following two reasons. This shouldn't cause any
functional changes.

   * The while loop is executed for once, meaning it's not needed
     in theory.
   * With the while loop removed, the nested statements can be
     avoid to make the code a bit cleaner.
Signed-off-by: default avatarGavin Shan <gshan@redhat.com>
Reviewed-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Link: https://lore.kernel.org/r/20200922130423.10173-10-gshan@redhat.comSigned-off-by: default avatarWill Deacon <will@kernel.org>
parent 1bbc7551
...@@ -491,24 +491,23 @@ int sdei_event_unregister(u32 event_num) ...@@ -491,24 +491,23 @@ int sdei_event_unregister(u32 event_num)
mutex_lock(&sdei_events_lock); mutex_lock(&sdei_events_lock);
event = sdei_event_find(event_num); event = sdei_event_find(event_num);
do { if (!event) {
if (!event) { pr_warn("Event %u not registered\n", event_num);
pr_warn("Event %u not registered\n", event_num); err = -ENOENT;
err = -ENOENT; goto unlock;
break; }
}
spin_lock(&sdei_list_lock); spin_lock(&sdei_list_lock);
event->reregister = false; event->reregister = false;
event->reenable = false; event->reenable = false;
spin_unlock(&sdei_list_lock); spin_unlock(&sdei_list_lock);
err = _sdei_event_unregister(event); err = _sdei_event_unregister(event);
if (err) if (err)
break; goto unlock;
sdei_event_destroy(event); sdei_event_destroy(event);
} while (0); unlock:
mutex_unlock(&sdei_events_lock); mutex_unlock(&sdei_events_lock);
return err; return err;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment