Commit b1571a0e authored by Dan Carpenter's avatar Dan Carpenter Committed by Felix Fietkau

mt76: Fix a signedness bug in mt7615_add_interface()

The problem is that "mvif->omac_idx" is a u8 so it can't be negative
and the error handling won't work.  The get_omac_idx() function returns
-1 on error.

Fixes: 04b8e659 ("mt76: add mac80211 driver for MT7615 PCIe-based chipsets")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarFelix Fietkau <nbd@nbd.name>
parent 4875e346
...@@ -77,11 +77,12 @@ static int mt7615_add_interface(struct ieee80211_hw *hw, ...@@ -77,11 +77,12 @@ static int mt7615_add_interface(struct ieee80211_hw *hw,
goto out; goto out;
} }
mvif->omac_idx = get_omac_idx(vif->type, dev->omac_mask); idx = get_omac_idx(vif->type, dev->omac_mask);
if (mvif->omac_idx < 0) { if (idx < 0) {
ret = -ENOSPC; ret = -ENOSPC;
goto out; goto out;
} }
mvif->omac_idx = idx;
/* TODO: DBDC support. Use band 0 and wmm 0 for now */ /* TODO: DBDC support. Use band 0 and wmm 0 for now */
mvif->band_idx = 0; mvif->band_idx = 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment