Commit b20fb13c authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Greg Kroah-Hartman

serial: stm32: Fix comparisons with undefined register

    drivers/tty/serial/stm32-usart.c: In function ‘stm32_receive_chars’:
    drivers/tty/serial/stm32-usart.c:130: warning: comparison is always true due to limited range of data type
    drivers/tty/serial/stm32-usart.c: In function ‘stm32_tx_dma_complete’:
    drivers/tty/serial/stm32-usart.c:177: warning: comparison is always false due to limited range of data type

stm32_usart_offsets.icr is u8, while UNDEF_REG = ~0 is int, and thus
0xffffffff.

As all registers in stm32_usart_offsets are u8, change the definition of
UNDEF_REG to 0xff to fix this.

Fixes: ada8618f ("serial: stm32: adding support for stm32f7")
Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 42acfc66
...@@ -31,7 +31,7 @@ struct stm32_usart_info { ...@@ -31,7 +31,7 @@ struct stm32_usart_info {
struct stm32_usart_config cfg; struct stm32_usart_config cfg;
}; };
#define UNDEF_REG ~0 #define UNDEF_REG 0xff
/* Register offsets */ /* Register offsets */
struct stm32_usart_info stm32f4_info = { struct stm32_usart_info stm32f4_info = {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment