Commit b2ab5990 authored by takis@lumumba.luc.ac.be's avatar takis@lumumba.luc.ac.be Committed by Jeff Garzik

[PATCH] Possible AMD8111e free irq issue

It seems to me that if in the amd8111e_open() fuction dev->irq isn't
zero and the irq request succeeds it might not get released anymore.

Specifically, on failure of the amd8111e_restart() call the function
returns -ENOMEM without releasing the irq. The amd8111e_restart()
function can fail because of various pci_alloc_consistent() and
dev_alloc_skb() calls in amd8111e_init_ring() which is being
called by amd8111e_restart.

1374     if(dev->irq ==0 || request_irq(dev->irq, amd8111e_interrupt, SA_SHIRQ,
1375                      dev->name, dev))
1376         return -EAGAIN;
Signed-off-by: default avatarJeff Garzik <jgarzik@pobox.com>
parent 1274fcd6
......@@ -1381,6 +1381,8 @@ static int amd8111e_open(struct net_device * dev )
if(amd8111e_restart(dev)){
spin_unlock_irq(&lp->lock);
if (dev->irq)
free_irq(dev->irq, dev);
return -ENOMEM;
}
/* Start ipg timer */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment