Commit b4b1d040 authored by Ezequiel Garcia's avatar Ezequiel Garcia Committed by Mauro Carvalho Chehab

[media] bttv: Replace memcpy with struct assignment

This kind of memcpy() is error-prone. Its replacement with a struct
assignment is prefered because it's type-safe and much easier to read.
Found by coccinelle. Hand patched and reviewed.
Tested by compilation only.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier struct_name;
struct struct_name to;
struct struct_name from;
expression E;
@@
-memcpy(&(to), &(from), E);
+to = from;
// </smpl>
Signed-off-by: default avatarPeter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: default avatarEzequiel Garcia <elezegarcia@gmail.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 2e814af5
...@@ -366,8 +366,7 @@ int __devinit init_bttv_i2c(struct bttv *btv) ...@@ -366,8 +366,7 @@ int __devinit init_bttv_i2c(struct bttv *btv)
strlcpy(btv->c.i2c_adap.name, "bttv", strlcpy(btv->c.i2c_adap.name, "bttv",
sizeof(btv->c.i2c_adap.name)); sizeof(btv->c.i2c_adap.name));
memcpy(&btv->i2c_algo, &bttv_i2c_algo_bit_template, btv->i2c_algo = bttv_i2c_algo_bit_template;
sizeof(bttv_i2c_algo_bit_template));
btv->i2c_algo.udelay = i2c_udelay; btv->i2c_algo.udelay = i2c_udelay;
btv->i2c_algo.data = btv; btv->i2c_algo.data = btv;
btv->c.i2c_adap.algo_data = &btv->i2c_algo; btv->c.i2c_adap.algo_data = &btv->i2c_algo;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment