Commit b6d80852 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman

greybus: es2: fix endpoint requirement check

The current es2 implementation only checks for no IN or OUT bulk
endpoints, but still assumes there are precisely NUM_BULKS of each.

Specifically, urbs could be allocated and initialised to default values,
which amounts to bulk urbs being submitted to the control endpoint.

We should be able to handle any number of endpoints, but for now let's
just require NUM_BULKS of each.
Signed-off-by: default avatarJohan Hovold <johan@hovoldconsulting.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@google.com>
parent a51e8551
...@@ -848,8 +848,7 @@ static int ap_probe(struct usb_interface *interface, ...@@ -848,8 +848,7 @@ static int ap_probe(struct usb_interface *interface,
endpoint->bEndpointAddress); endpoint->bEndpointAddress);
} }
} }
if ((bulk_in == 0) || if (bulk_in != NUM_BULKS || bulk_out != NUM_BULKS) {
(bulk_out == 0)) {
dev_err(&udev->dev, "Not enough endpoints found in device, aborting!\n"); dev_err(&udev->dev, "Not enough endpoints found in device, aborting!\n");
goto error; goto error;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment