Commit b7b95fb8 authored by James Smart's avatar James Smart Committed by Martin K. Petersen

scsi: lpfc: Fix miss of register read failure check

Coverity flagged missing status check on register read that flags a
poisoned data return value.

Add checking of register read status.

Link: https://lore.kernel.org/r/20190922035906.10977-4-jsmart2021@gmail.comSigned-off-by: default avatarDick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: default avatarJames Smart <jsmart2021@gmail.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 65a3df63
...@@ -1475,8 +1475,9 @@ lpfc_sli4_pdev_status_reg_wait(struct lpfc_hba *phba) ...@@ -1475,8 +1475,9 @@ lpfc_sli4_pdev_status_reg_wait(struct lpfc_hba *phba)
int i; int i;
msleep(100); msleep(100);
lpfc_readl(phba->sli4_hba.u.if_type2.STATUSregaddr, if (lpfc_readl(phba->sli4_hba.u.if_type2.STATUSregaddr,
&portstat_reg.word0); &portstat_reg.word0))
return -EIO;
/* verify if privileged for the request operation */ /* verify if privileged for the request operation */
if (!bf_get(lpfc_sliport_status_rn, &portstat_reg) && if (!bf_get(lpfc_sliport_status_rn, &portstat_reg) &&
...@@ -1486,8 +1487,9 @@ lpfc_sli4_pdev_status_reg_wait(struct lpfc_hba *phba) ...@@ -1486,8 +1487,9 @@ lpfc_sli4_pdev_status_reg_wait(struct lpfc_hba *phba)
/* wait for the SLI port firmware ready after firmware reset */ /* wait for the SLI port firmware ready after firmware reset */
for (i = 0; i < LPFC_FW_RESET_MAXIMUM_WAIT_10MS_CNT; i++) { for (i = 0; i < LPFC_FW_RESET_MAXIMUM_WAIT_10MS_CNT; i++) {
msleep(10); msleep(10);
lpfc_readl(phba->sli4_hba.u.if_type2.STATUSregaddr, if (lpfc_readl(phba->sli4_hba.u.if_type2.STATUSregaddr,
&portstat_reg.word0); &portstat_reg.word0))
continue;
if (!bf_get(lpfc_sliport_status_err, &portstat_reg)) if (!bf_get(lpfc_sliport_status_err, &portstat_reg))
continue; continue;
if (!bf_get(lpfc_sliport_status_rn, &portstat_reg)) if (!bf_get(lpfc_sliport_status_rn, &portstat_reg))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment