Commit b8bc83ab authored by Tvrtko Ursulin's avatar Tvrtko Ursulin Committed by James Morris

securityfs: Drop dentry reference count when mknod fails

lookup_one_len increments dentry reference count which is not decremented
when the create operation fails. This can cause a kernel BUG at
fs/dcache.c:676 at unmount time. Also error code returned when new_inode()
fails was replaced with more appropriate -ENOMEM.
Signed-off-by: default avatarTvrtko Ursulin <tvrtko.ursulin@sophos.com>
Acked-by: default avatarSerge E. Hallyn <serge@hallyn.com>
Acked-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: default avatarJames Morris <jmorris@namei.org>
parent 57a62c23
...@@ -86,7 +86,7 @@ static int mknod(struct inode *dir, struct dentry *dentry, ...@@ -86,7 +86,7 @@ static int mknod(struct inode *dir, struct dentry *dentry,
int mode, dev_t dev) int mode, dev_t dev)
{ {
struct inode *inode; struct inode *inode;
int error = -EPERM; int error = -ENOMEM;
if (dentry->d_inode) if (dentry->d_inode)
return -EEXIST; return -EEXIST;
...@@ -166,6 +166,8 @@ static int create_by_name(const char *name, mode_t mode, ...@@ -166,6 +166,8 @@ static int create_by_name(const char *name, mode_t mode,
error = mkdir(parent->d_inode, *dentry, mode); error = mkdir(parent->d_inode, *dentry, mode);
else else
error = create(parent->d_inode, *dentry, mode); error = create(parent->d_inode, *dentry, mode);
if (error)
dput(*dentry);
} else } else
error = PTR_ERR(*dentry); error = PTR_ERR(*dentry);
mutex_unlock(&parent->d_inode->i_mutex); mutex_unlock(&parent->d_inode->i_mutex);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment