Commit b93c3c7f authored by Andrey Pronin's avatar Andrey Pronin Committed by Ben Hutchings

tpm: read burstcount from TPM_STS in one 32-bit transaction

commit 9754d45e upstream.

Some chips incorrectly support partial reads from TPM_STS register
at non-zero offsets. Read the entire 32-bits register instead of
making two 8-bit reads to support such devices and reduce the number
of bus transactions when obtaining the burstcount from TPM_STS.

Fixes: 27084efe ("tpm: driver for next generation TPM chips")
Signed-off-by: default avatarAndrey Pronin <apronin@chromium.org>
Reviewed-by: default avatarJarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Signed-off-by: default avatarJarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
[bwh: Backported to 3.16:
 - Use raw ioread32() instead of tpm_tis_read32()
 - Adjust filename, context]
Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
parent 7bcd4f04
...@@ -197,16 +197,15 @@ static int get_burstcount(struct tpm_chip *chip) ...@@ -197,16 +197,15 @@ static int get_burstcount(struct tpm_chip *chip)
{ {
unsigned long stop; unsigned long stop;
int burstcnt; int burstcnt;
u32 value;
/* wait for burstcount */ /* wait for burstcount */
/* which timeout value, spec has 2 answers (c & d) */ /* which timeout value, spec has 2 answers (c & d) */
stop = jiffies + chip->vendor.timeout_d; stop = jiffies + chip->vendor.timeout_d;
do { do {
burstcnt = ioread8(chip->vendor.iobase + value = ioread32(chip->vendor.iobase +
TPM_STS(chip->vendor.locality) + 1); TPM_STS(chip->vendor.locality));
burstcnt += ioread8(chip->vendor.iobase + burstcnt = (value >> 8) & 0xFFFF;
TPM_STS(chip->vendor.locality) +
2) << 8;
if (burstcnt) if (burstcnt)
return burstcnt; return burstcnt;
msleep(TPM_TIMEOUT); msleep(TPM_TIMEOUT);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment