Commit baeababb authored by Jason Wang's avatar Jason Wang Committed by David S. Miller

tun: return NET_XMIT_DROP for dropped packets

After commit 5d097109
("tun: only queue packets on device"), NETDEV_TX_OK was returned for
dropped packets. This will confuse pktgen since dropped packets were
counted as sent ones.

Fixing this by returning NET_XMIT_DROP to let pktgen count it as error
packet.

Cc: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarJason Wang <jasowang@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e3e32170
...@@ -819,7 +819,7 @@ static netdev_tx_t tun_net_xmit(struct sk_buff *skb, struct net_device *dev) ...@@ -819,7 +819,7 @@ static netdev_tx_t tun_net_xmit(struct sk_buff *skb, struct net_device *dev)
skb_tx_error(skb); skb_tx_error(skb);
kfree_skb(skb); kfree_skb(skb);
rcu_read_unlock(); rcu_read_unlock();
return NETDEV_TX_OK; return NET_XMIT_DROP;
} }
static void tun_net_mclist(struct net_device *dev) static void tun_net_mclist(struct net_device *dev)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment