Commit baf5964e authored by Lubomir Rintel's avatar Lubomir Rintel Committed by Sebastian Reichel

power: supply: olpc_battery: force the le/be casts

The endianness of data returned from the EC depends on the particular EC
version determined at run time. Cast from little/big endian explicitey
in the routine that flips endianness to the native one to make sparse
happy.
Signed-off-by: default avatarLubomir Rintel <lkundrak@v3.sk>
Reported-by: default avatarkbuild test robot <lkp@intel.com>
Fixes: 76311b9a ("power: supply: olpc_battery: Add OLPC XO 1.75 support")
Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.com>
parent c8f3c9fe
...@@ -327,9 +327,9 @@ static int olpc_bat_get_voltage_max_design(union power_supply_propval *val) ...@@ -327,9 +327,9 @@ static int olpc_bat_get_voltage_max_design(union power_supply_propval *val)
static u16 ecword_to_cpu(struct olpc_battery_data *data, u16 ec_word) static u16 ecword_to_cpu(struct olpc_battery_data *data, u16 ec_word)
{ {
if (data->little_endian) if (data->little_endian)
return le16_to_cpu(ec_word); return le16_to_cpu((__force __le16)ec_word);
else else
return be16_to_cpu(ec_word); return be16_to_cpu((__force __be16)ec_word);
} }
/********************************************************************* /*********************************************************************
...@@ -341,7 +341,7 @@ static int olpc_bat_get_property(struct power_supply *psy, ...@@ -341,7 +341,7 @@ static int olpc_bat_get_property(struct power_supply *psy,
{ {
struct olpc_battery_data *data = power_supply_get_drvdata(psy); struct olpc_battery_data *data = power_supply_get_drvdata(psy);
int ret = 0; int ret = 0;
__be16 ec_word; u16 ec_word;
uint8_t ec_byte; uint8_t ec_byte;
__be64 ser_buf; __be64 ser_buf;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment