Commit bbf4ac9c authored by Heiner Kallweit's avatar Heiner Kallweit Committed by Jiri Kosina

HID: thingm: remove not needed error message

LED core takes care of handling failed calls to thingm_let_set.
- print error message in set_brightness_delayed or
- pass error to caller in led_set_brightness_sync
Also the error message here doesn't provide any hint what actually
went wrong. Therefore remove it.
Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: default avatarBenjamin Tissoires <benjamin.tissoires@rehat.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent a4362fd6
...@@ -148,13 +148,8 @@ static int thingm_led_set(struct led_classdev *ldev, ...@@ -148,13 +148,8 @@ static int thingm_led_set(struct led_classdev *ldev,
enum led_brightness brightness) enum led_brightness brightness)
{ {
struct thingm_led *led = container_of(ldev, struct thingm_led, ldev); struct thingm_led *led = container_of(ldev, struct thingm_led, ldev);
int ret;
ret = thingm_write_color(led->rgb);
if (ret)
hid_err(led->rgb->tdev->hdev, "failed to write color\n");
return ret; return thingm_write_color(led->rgb);
} }
static int thingm_init_led(struct thingm_led *led, const char *color_name, static int thingm_init_led(struct thingm_led *led, const char *color_name,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment