Commit bc8d9d42 authored by Jiri Slaby's avatar Jiri Slaby Committed by Ben Hutchings

tty: vt, return error when con_startup fails

commit 6798df4c upstream.

When csw->con_startup() fails in do_register_con_driver, we return no
error (i.e. 0). This was changed back in 2006 by commit 3e795de7.
Before that we used to return -ENODEV.

So fix the return value to be -ENODEV in that case again.

Fixes: 3e795de7 ("VT binding: Add binding/unbinding support for the VT console")
Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
Reported-by: default avatar"Dan Carpenter" <dan.carpenter@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
parent dae2881c
...@@ -3550,9 +3550,10 @@ static int do_register_con_driver(const struct consw *csw, int first, int last) ...@@ -3550,9 +3550,10 @@ static int do_register_con_driver(const struct consw *csw, int first, int last)
goto err; goto err;
desc = csw->con_startup(); desc = csw->con_startup();
if (!desc) {
if (!desc) retval = -ENODEV;
goto err; goto err;
}
retval = -EINVAL; retval = -EINVAL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment