Commit bcd357a2 authored by Anton Altaparmakov's avatar Anton Altaparmakov

NTFS: Fix warnings on x86-64. (Randy Dunlap with slight modification from me)

Fix printk arg type warnings on x86-64 (and OK on x86-32) (gcc 3.3.3):
fs/ntfs/dir.c:1272: warning: long long unsigned int format, long unsigned int arg (arg 6)
fs/ntfs/dir.c:1388: warning: long long unsigned int format, long unsigned int arg (arg 5
Signed-off-by: default avatarRandy Dunlap <rddunlap@osdl.org>
Signed-off-by: default avatarAnton Altaparmakov <aia21@cantab.net>
parent faed8cc6
...@@ -68,6 +68,8 @@ ToDo/Notes: ...@@ -68,6 +68,8 @@ ToDo/Notes:
- Update fs/ntfs/inode.c::ntfs_write_inode() to also use the helper - Update fs/ntfs/inode.c::ntfs_write_inode() to also use the helper
mark_ntfs_record_dirty() and thus to set the buffers belonging to the mark_ntfs_record_dirty() and thus to set the buffers belonging to the
mft record dirty as well as the page itself. mft record dirty as well as the page itself.
- Fix compiler warnings on x86-64 in fs/ntfs/dir.c. (Randy Dunlap,
slightly modified by me)
2.1.20 - Fix two stupid bugs introduced in 2.1.18 release. 2.1.20 - Fix two stupid bugs introduced in 2.1.18 release.
......
...@@ -1278,7 +1278,7 @@ static int ntfs_readdir(struct file *filp, void *dirent, filldir_t filldir) ...@@ -1278,7 +1278,7 @@ static int ntfs_readdir(struct file *filp, void *dirent, filldir_t filldir)
ntfs_debug("Reading bitmap with page index 0x%llx, bit ofs 0x%llx", ntfs_debug("Reading bitmap with page index 0x%llx, bit ofs 0x%llx",
(unsigned long long)bmp_pos >> (3 + PAGE_CACHE_SHIFT), (unsigned long long)bmp_pos >> (3 + PAGE_CACHE_SHIFT),
(unsigned long long)bmp_pos & (unsigned long long)bmp_pos &
((PAGE_CACHE_SIZE * 8) - 1)); (unsigned long long)((PAGE_CACHE_SIZE * 8) - 1));
bmp_page = ntfs_map_page(bmp_mapping, bmp_page = ntfs_map_page(bmp_mapping,
bmp_pos >> (3 + PAGE_CACHE_SHIFT)); bmp_pos >> (3 + PAGE_CACHE_SHIFT));
if (IS_ERR(bmp_page)) { if (IS_ERR(bmp_page)) {
...@@ -1392,8 +1392,8 @@ static int ntfs_readdir(struct file *filp, void *dirent, filldir_t filldir) ...@@ -1392,8 +1392,8 @@ static int ntfs_readdir(struct file *filp, void *dirent, filldir_t filldir)
*/ */
for (;; ie = (INDEX_ENTRY*)((u8*)ie + le16_to_cpu(ie->length))) { for (;; ie = (INDEX_ENTRY*)((u8*)ie + le16_to_cpu(ie->length))) {
ntfs_debug("In index allocation, offset 0x%llx.", ntfs_debug("In index allocation, offset 0x%llx.",
(unsigned long long)ia_start + ((u8*)ie - (unsigned long long)ia_start +
(u8*)ia)); (unsigned long long)((u8*)ie - (u8*)ia));
/* Bounds checks. */ /* Bounds checks. */
if (unlikely((u8*)ie < (u8*)ia || (u8*)ie + if (unlikely((u8*)ie < (u8*)ia || (u8*)ie +
sizeof(INDEX_ENTRY_HEADER) > index_end || sizeof(INDEX_ENTRY_HEADER) > index_end ||
......
...@@ -25,7 +25,7 @@ ...@@ -25,7 +25,7 @@
#include <linux/quotaops.h> #include <linux/quotaops.h>
#include <linux/mount.h> #include <linux/mount.h>
#include "ntfs.h" #include "aops.h"
#include "dir.h" #include "dir.h"
#include "debug.h" #include "debug.h"
#include "inode.h" #include "inode.h"
...@@ -33,6 +33,7 @@ ...@@ -33,6 +33,7 @@
#include "malloc.h" #include "malloc.h"
#include "mft.h" #include "mft.h"
#include "time.h" #include "time.h"
#include "ntfs.h"
/** /**
* ntfs_test_inode - compare two (possibly fake) inodes for equality * ntfs_test_inode - compare two (possibly fake) inodes for equality
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment