Commit bd0d9379 authored by Alexandre Belloni's avatar Alexandre Belloni

rtc: rv3029: remove useless error messages

Remove redundant messages or messages that would not add any value because
the information is already conveyed properly using errno.

Link: https://lore.kernel.org/r/20191223100108.1083078-1-alexandre.belloni@bootlin.comSigned-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent fc219291
...@@ -318,10 +318,8 @@ static int rv3029_read_time(struct device *dev, struct rtc_time *tm) ...@@ -318,10 +318,8 @@ static int rv3029_read_time(struct device *dev, struct rtc_time *tm)
ret = regmap_bulk_read(rv3029->regmap, RV3029_W_SEC, regs, ret = regmap_bulk_read(rv3029->regmap, RV3029_W_SEC, regs,
RV3029_WATCH_SECTION_LEN); RV3029_WATCH_SECTION_LEN);
if (ret < 0) { if (ret < 0)
dev_err(dev, "%s: reading RTC section failed\n", __func__);
return ret; return ret;
}
tm->tm_sec = bcd2bin(regs[RV3029_W_SEC - RV3029_W_SEC]); tm->tm_sec = bcd2bin(regs[RV3029_W_SEC - RV3029_W_SEC]);
tm->tm_min = bcd2bin(regs[RV3029_W_MINUTES - RV3029_W_SEC]); tm->tm_min = bcd2bin(regs[RV3029_W_MINUTES - RV3029_W_SEC]);
...@@ -357,21 +355,16 @@ static int rv3029_read_alarm(struct device *dev, struct rtc_wkalrm *alarm) ...@@ -357,21 +355,16 @@ static int rv3029_read_alarm(struct device *dev, struct rtc_wkalrm *alarm)
ret = regmap_bulk_read(rv3029->regmap, RV3029_A_SC, regs, ret = regmap_bulk_read(rv3029->regmap, RV3029_A_SC, regs,
RV3029_ALARM_SECTION_LEN); RV3029_ALARM_SECTION_LEN);
if (ret < 0) { if (ret < 0)
dev_err(dev, "%s: reading alarm section failed\n", __func__);
return ret; return ret;
}
ret = regmap_read(rv3029->regmap, RV3029_IRQ_CTRL, &controls); ret = regmap_read(rv3029->regmap, RV3029_IRQ_CTRL, &controls);
if (ret) { if (ret)
dev_err(dev, "Read IRQ Control Register error %d\n", ret);
return ret; return ret;
}
ret = regmap_read(rv3029->regmap, RV3029_IRQ_FLAGS, &flags); ret = regmap_read(rv3029->regmap, RV3029_IRQ_FLAGS, &flags);
if (ret < 0) { if (ret < 0)
dev_err(dev, "Read IRQ Flags Register error %d\n", ret);
return ret; return ret;
}
tm->tm_sec = bcd2bin(regs[RV3029_A_SC - RV3029_A_SC] & 0x7f); tm->tm_sec = bcd2bin(regs[RV3029_A_SC - RV3029_A_SC] & 0x7f);
tm->tm_min = bcd2bin(regs[RV3029_A_MN - RV3029_A_SC] & 0x7f); tm->tm_min = bcd2bin(regs[RV3029_A_MN - RV3029_A_SC] & 0x7f);
...@@ -802,11 +795,8 @@ static int rv3029_i2c_probe(struct i2c_client *client, ...@@ -802,11 +795,8 @@ static int rv3029_i2c_probe(struct i2c_client *client,
} }
regmap = devm_regmap_init_i2c(client, &config); regmap = devm_regmap_init_i2c(client, &config);
if (IS_ERR(regmap)) { if (IS_ERR(regmap))
dev_err(&client->dev, "%s: regmap allocation failed: %ld\n",
__func__, PTR_ERR(regmap));
return PTR_ERR(regmap); return PTR_ERR(regmap);
}
return rv3029_probe(&client->dev, regmap, client->irq, client->name); return rv3029_probe(&client->dev, regmap, client->irq, client->name);
} }
...@@ -863,11 +853,8 @@ static int rv3049_probe(struct spi_device *spi) ...@@ -863,11 +853,8 @@ static int rv3049_probe(struct spi_device *spi)
struct regmap *regmap; struct regmap *regmap;
regmap = devm_regmap_init_spi(spi, &config); regmap = devm_regmap_init_spi(spi, &config);
if (IS_ERR(regmap)) { if (IS_ERR(regmap))
dev_err(&spi->dev, "%s: regmap allocation failed: %ld\n",
__func__, PTR_ERR(regmap));
return PTR_ERR(regmap); return PTR_ERR(regmap);
}
return rv3029_probe(&spi->dev, regmap, spi->irq, "rv3049"); return rv3029_probe(&spi->dev, regmap, spi->irq, "rv3049");
} }
...@@ -907,16 +894,12 @@ static int __init rv30x9_init(void) ...@@ -907,16 +894,12 @@ static int __init rv30x9_init(void)
int ret; int ret;
ret = rv3029_register_driver(); ret = rv3029_register_driver();
if (ret) { if (ret)
pr_err("Failed to register rv3029 driver: %d\n", ret);
return ret; return ret;
}
ret = rv3049_register_driver(); ret = rv3049_register_driver();
if (ret) { if (ret)
pr_err("Failed to register rv3049 driver: %d\n", ret);
rv3029_unregister_driver(); rv3029_unregister_driver();
}
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment