Commit bdd4034d authored by Rabin Vincent's avatar Rabin Vincent Committed by Greg Kroah-Hartman

driver core: always handle dpm_order

If !dev->class, device_move() does not respect the dpm_order.
Fix it to do so.
Acked-by: default avatarRafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: default avatarRabin Vincent <rabin.vincent@stericsson.com>
Reviewed-by: default avatarSrinidhi Kasagar <srinidhi.kasagar@stericsson.com>
[Fixed a small dangling label compile warning]
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent cfaf0251
...@@ -1754,25 +1754,25 @@ int device_move(struct device *dev, struct device *new_parent, ...@@ -1754,25 +1754,25 @@ int device_move(struct device *dev, struct device *new_parent,
set_dev_node(dev, dev_to_node(new_parent)); set_dev_node(dev, dev_to_node(new_parent));
} }
if (!dev->class) if (dev->class) {
goto out_put; error = device_move_class_links(dev, old_parent, new_parent);
error = device_move_class_links(dev, old_parent, new_parent); if (error) {
if (error) { /* We ignore errors on cleanup since we're hosed anyway... */
/* We ignore errors on cleanup since we're hosed anyway... */ device_move_class_links(dev, new_parent, old_parent);
device_move_class_links(dev, new_parent, old_parent); if (!kobject_move(&dev->kobj, &old_parent->kobj)) {
if (!kobject_move(&dev->kobj, &old_parent->kobj)) { if (new_parent)
if (new_parent) klist_remove(&dev->p->knode_parent);
klist_remove(&dev->p->knode_parent); dev->parent = old_parent;
dev->parent = old_parent; if (old_parent) {
if (old_parent) { klist_add_tail(&dev->p->knode_parent,
klist_add_tail(&dev->p->knode_parent, &old_parent->p->klist_children);
&old_parent->p->klist_children); set_dev_node(dev, dev_to_node(old_parent));
set_dev_node(dev, dev_to_node(old_parent)); }
} }
cleanup_glue_dir(dev, new_parent_kobj);
put_device(new_parent);
goto out;
} }
cleanup_glue_dir(dev, new_parent_kobj);
put_device(new_parent);
goto out;
} }
switch (dpm_order) { switch (dpm_order) {
case DPM_ORDER_NONE: case DPM_ORDER_NONE:
...@@ -1787,7 +1787,7 @@ int device_move(struct device *dev, struct device *new_parent, ...@@ -1787,7 +1787,7 @@ int device_move(struct device *dev, struct device *new_parent,
device_pm_move_last(dev); device_pm_move_last(dev);
break; break;
} }
out_put:
put_device(old_parent); put_device(old_parent);
out: out:
device_pm_unlock(); device_pm_unlock();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment