Commit be01363f authored by John Harrison's avatar John Harrison Committed by Daniel Vetter

drm/i915: Update render_state_init() to take a request structure

Updated the two render_state_init() functions to take a request pointer instead
of a ring. This removes their reliance on the OLR.

v2: Rebased to newer tree.

For: VIZ-5115
Signed-off-by: default avatarJohn Harrison <John.C.Harrison@Intel.com>
Reviewed-by: default avatarTomas Elf <tomas.elf@intel.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 8753181e
...@@ -152,26 +152,26 @@ int i915_gem_render_state_prepare(struct intel_engine_cs *ring, ...@@ -152,26 +152,26 @@ int i915_gem_render_state_prepare(struct intel_engine_cs *ring,
return 0; return 0;
} }
int i915_gem_render_state_init(struct intel_engine_cs *ring) int i915_gem_render_state_init(struct drm_i915_gem_request *req)
{ {
struct render_state so; struct render_state so;
int ret; int ret;
ret = i915_gem_render_state_prepare(ring, &so); ret = i915_gem_render_state_prepare(req->ring, &so);
if (ret) if (ret)
return ret; return ret;
if (so.rodata == NULL) if (so.rodata == NULL)
return 0; return 0;
ret = ring->dispatch_execbuffer(ring, ret = req->ring->dispatch_execbuffer(req->ring,
so.ggtt_offset, so.ggtt_offset,
so.rodata->batch_items * 4, so.rodata->batch_items * 4,
I915_DISPATCH_SECURE); I915_DISPATCH_SECURE);
if (ret) if (ret)
goto out; goto out;
i915_vma_move_to_active(i915_gem_obj_to_ggtt(so.obj), ring); i915_vma_move_to_active(i915_gem_obj_to_ggtt(so.obj), req->ring);
out: out:
i915_gem_render_state_fini(&so); i915_gem_render_state_fini(&so);
......
...@@ -39,7 +39,7 @@ struct render_state { ...@@ -39,7 +39,7 @@ struct render_state {
int gen; int gen;
}; };
int i915_gem_render_state_init(struct intel_engine_cs *ring); int i915_gem_render_state_init(struct drm_i915_gem_request *req);
void i915_gem_render_state_fini(struct render_state *so); void i915_gem_render_state_fini(struct render_state *so);
int i915_gem_render_state_prepare(struct intel_engine_cs *ring, int i915_gem_render_state_prepare(struct intel_engine_cs *ring,
struct render_state *so); struct render_state *so);
......
...@@ -1574,28 +1574,26 @@ static int gen8_emit_request(struct intel_ringbuffer *ringbuf, ...@@ -1574,28 +1574,26 @@ static int gen8_emit_request(struct intel_ringbuffer *ringbuf,
return 0; return 0;
} }
static int intel_lr_context_render_state_init(struct intel_engine_cs *ring, static int intel_lr_context_render_state_init(struct drm_i915_gem_request *req)
struct intel_context *ctx)
{ {
struct intel_ringbuffer *ringbuf = ctx->engine[ring->id].ringbuf;
struct render_state so; struct render_state so;
int ret; int ret;
ret = i915_gem_render_state_prepare(ring, &so); ret = i915_gem_render_state_prepare(req->ring, &so);
if (ret) if (ret)
return ret; return ret;
if (so.rodata == NULL) if (so.rodata == NULL)
return 0; return 0;
ret = ring->emit_bb_start(ringbuf, ret = req->ring->emit_bb_start(req->ringbuf,
ctx, req->ctx,
so.ggtt_offset, so.ggtt_offset,
I915_DISPATCH_SECURE); I915_DISPATCH_SECURE);
if (ret) if (ret)
goto out; goto out;
i915_vma_move_to_active(i915_gem_obj_to_ggtt(so.obj), ring); i915_vma_move_to_active(i915_gem_obj_to_ggtt(so.obj), req->ring);
out: out:
i915_gem_render_state_fini(&so); i915_gem_render_state_fini(&so);
...@@ -1610,7 +1608,7 @@ static int gen8_init_rcs_context(struct drm_i915_gem_request *req) ...@@ -1610,7 +1608,7 @@ static int gen8_init_rcs_context(struct drm_i915_gem_request *req)
if (ret) if (ret)
return ret; return ret;
return intel_lr_context_render_state_init(req->ring, req->ctx); return intel_lr_context_render_state_init(req);
} }
/** /**
......
...@@ -750,7 +750,7 @@ static int intel_rcs_ctx_init(struct drm_i915_gem_request *req) ...@@ -750,7 +750,7 @@ static int intel_rcs_ctx_init(struct drm_i915_gem_request *req)
if (ret != 0) if (ret != 0)
return ret; return ret;
ret = i915_gem_render_state_init(req->ring); ret = i915_gem_render_state_init(req);
if (ret) if (ret)
DRM_ERROR("init render state: %d\n", ret); DRM_ERROR("init render state: %d\n", ret);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment