Commit bf63b9d4 authored by Eric Biggers's avatar Eric Biggers Committed by Greg Kroah-Hartman

fscrypto: require write access to mount to set encryption policy

commit ba63f23d upstream.

Since setting an encryption policy requires writing metadata to the
filesystem, it should be guarded by mnt_want_write/mnt_drop_write.
Otherwise, a user could cause a write to a frozen or readonly
filesystem.  This was handled correctly by f2fs but not by ext4.  Make
fscrypt_process_policy() handle it rather than relying on the filesystem
to get it right.
Signed-off-by: default avatarEric Biggers <ebiggers@google.com>
Cc: stable@vger.kernel.org # 4.1+; check fs/{ext4,f2fs}
Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
Acked-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 92c67861
......@@ -629,7 +629,13 @@ long ext4_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
goto encryption_policy_out;
}
err = mnt_want_write_file(filp);
if (err)
goto encryption_policy_out;
err = ext4_process_policy(&policy, inode);
mnt_drop_write_file(filp);
encryption_policy_out:
return err;
#else
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment