Commit c0a56a2a authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman

USB: garmin_gps.c: remove dbg() tracing calls

dbg() was used a lot a long time ago to trace code flow.  Now that we have
ftrace, this isn't needed at all, so remove these calls.

CC: Johan Hovold <jhovold@gmail.com>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: Rusty Russell <rusty@rustcorp.com.au>
CC: Mike Frysinger <vapier@gentoo.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a09aa7dd
...@@ -345,8 +345,6 @@ static void pkt_clear(struct garmin_data *garmin_data_p) ...@@ -345,8 +345,6 @@ static void pkt_clear(struct garmin_data *garmin_data_p)
unsigned long flags; unsigned long flags;
struct garmin_packet *result = NULL; struct garmin_packet *result = NULL;
dbg("%s", __func__);
spin_lock_irqsave(&garmin_data_p->lock, flags); spin_lock_irqsave(&garmin_data_p->lock, flags);
while (!list_empty(&garmin_data_p->pktlist)) { while (!list_empty(&garmin_data_p->pktlist)) {
result = (struct garmin_packet *)garmin_data_p->pktlist.next; result = (struct garmin_packet *)garmin_data_p->pktlist.next;
...@@ -939,8 +937,6 @@ static int garmin_open(struct tty_struct *tty, struct usb_serial_port *port) ...@@ -939,8 +937,6 @@ static int garmin_open(struct tty_struct *tty, struct usb_serial_port *port)
int status = 0; int status = 0;
struct garmin_data *garmin_data_p = usb_get_serial_port_data(port); struct garmin_data *garmin_data_p = usb_get_serial_port_data(port);
dbg("%s - port %d", __func__, port->number);
spin_lock_irqsave(&garmin_data_p->lock, flags); spin_lock_irqsave(&garmin_data_p->lock, flags);
garmin_data_p->mode = initial_mode; garmin_data_p->mode = initial_mode;
garmin_data_p->count = 0; garmin_data_p->count = 0;
...@@ -996,8 +992,6 @@ static void garmin_write_bulk_callback(struct urb *urb) ...@@ -996,8 +992,6 @@ static void garmin_write_bulk_callback(struct urb *urb)
struct garmin_data *garmin_data_p = struct garmin_data *garmin_data_p =
usb_get_serial_port_data(port); usb_get_serial_port_data(port);
dbg("%s - port %d", __func__, port->number);
if (GARMIN_LAYERID_APPL == getLayerId(urb->transfer_buffer)) { if (GARMIN_LAYERID_APPL == getLayerId(urb->transfer_buffer)) {
if (garmin_data_p->mode == MODE_GARMIN_SERIAL) { if (garmin_data_p->mode == MODE_GARMIN_SERIAL) {
...@@ -1027,9 +1021,6 @@ static int garmin_write_bulk(struct usb_serial_port *port, ...@@ -1027,9 +1021,6 @@ static int garmin_write_bulk(struct usb_serial_port *port,
unsigned char *buffer; unsigned char *buffer;
int status; int status;
dbg("%s - port %d, state %d", __func__, port->number,
garmin_data_p->state);
spin_lock_irqsave(&garmin_data_p->lock, flags); spin_lock_irqsave(&garmin_data_p->lock, flags);
garmin_data_p->flags &= ~FLAGS_DROP_DATA; garmin_data_p->flags &= ~FLAGS_DROP_DATA;
spin_unlock_irqrestore(&garmin_data_p->lock, flags); spin_unlock_irqrestore(&garmin_data_p->lock, flags);
...@@ -1224,8 +1215,6 @@ static void garmin_read_bulk_callback(struct urb *urb) ...@@ -1224,8 +1215,6 @@ static void garmin_read_bulk_callback(struct urb *urb)
int status = urb->status; int status = urb->status;
int retval; int retval;
dbg("%s - port %d", __func__, port->number);
if (!serial) { if (!serial) {
dbg("%s - bad serial pointer, exiting", __func__); dbg("%s - bad serial pointer, exiting", __func__);
return; return;
...@@ -1384,7 +1373,6 @@ static void garmin_throttle(struct tty_struct *tty) ...@@ -1384,7 +1373,6 @@ static void garmin_throttle(struct tty_struct *tty)
struct usb_serial_port *port = tty->driver_data; struct usb_serial_port *port = tty->driver_data;
struct garmin_data *garmin_data_p = usb_get_serial_port_data(port); struct garmin_data *garmin_data_p = usb_get_serial_port_data(port);
dbg("%s - port %d", __func__, port->number);
/* set flag, data received will be put into a queue /* set flag, data received will be put into a queue
for later processing */ for later processing */
spin_lock_irq(&garmin_data_p->lock); spin_lock_irq(&garmin_data_p->lock);
...@@ -1399,7 +1387,6 @@ static void garmin_unthrottle(struct tty_struct *tty) ...@@ -1399,7 +1387,6 @@ static void garmin_unthrottle(struct tty_struct *tty)
struct garmin_data *garmin_data_p = usb_get_serial_port_data(port); struct garmin_data *garmin_data_p = usb_get_serial_port_data(port);
int status; int status;
dbg("%s - port %d", __func__, port->number);
spin_lock_irq(&garmin_data_p->lock); spin_lock_irq(&garmin_data_p->lock);
garmin_data_p->flags &= ~FLAGS_THROTTLED; garmin_data_p->flags &= ~FLAGS_THROTTLED;
spin_unlock_irq(&garmin_data_p->lock); spin_unlock_irq(&garmin_data_p->lock);
...@@ -1441,8 +1428,6 @@ static int garmin_attach(struct usb_serial *serial) ...@@ -1441,8 +1428,6 @@ static int garmin_attach(struct usb_serial *serial)
struct usb_serial_port *port = serial->port[0]; struct usb_serial_port *port = serial->port[0];
struct garmin_data *garmin_data_p = NULL; struct garmin_data *garmin_data_p = NULL;
dbg("%s", __func__);
garmin_data_p = kzalloc(sizeof(struct garmin_data), GFP_KERNEL); garmin_data_p = kzalloc(sizeof(struct garmin_data), GFP_KERNEL);
if (garmin_data_p == NULL) { if (garmin_data_p == NULL) {
dev_err(&port->dev, "%s - Out of memory\n", __func__); dev_err(&port->dev, "%s - Out of memory\n", __func__);
...@@ -1471,8 +1456,6 @@ static void garmin_disconnect(struct usb_serial *serial) ...@@ -1471,8 +1456,6 @@ static void garmin_disconnect(struct usb_serial *serial)
struct usb_serial_port *port = serial->port[0]; struct usb_serial_port *port = serial->port[0];
struct garmin_data *garmin_data_p = usb_get_serial_port_data(port); struct garmin_data *garmin_data_p = usb_get_serial_port_data(port);
dbg("%s", __func__);
usb_kill_urb(port->interrupt_in_urb); usb_kill_urb(port->interrupt_in_urb);
del_timer_sync(&garmin_data_p->timer); del_timer_sync(&garmin_data_p->timer);
} }
...@@ -1483,8 +1466,6 @@ static void garmin_release(struct usb_serial *serial) ...@@ -1483,8 +1466,6 @@ static void garmin_release(struct usb_serial *serial)
struct usb_serial_port *port = serial->port[0]; struct usb_serial_port *port = serial->port[0];
struct garmin_data *garmin_data_p = usb_get_serial_port_data(port); struct garmin_data *garmin_data_p = usb_get_serial_port_data(port);
dbg("%s", __func__);
kfree(garmin_data_p); kfree(garmin_data_p);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment