Commit c0ca8df7 authored by Noam Camus's avatar Noam Camus Committed by Thomas Gleixner

irqchip/eznps: Acknowledge NPS_IPI before calling the handler

IPI_IRQ (also TIMER0_IRQ) should be acked before the action->handler is called
in handle_percpu_devid_irq.

The IPI irq is edge sensitive and we might miss an IPI interrupt if it is
triggered again while the handler runs.

Fixes: 44df427c ("irqchip: add nps Internal and external irqchips")
Signed-off-by: default avatarNoam Camus <noamca@mellanox.com>
Cc: marc.zyngier@arm.com
Cc: jason@lakedaemon.net
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/1476364532-12634-1-git-send-email-noamca@mellanox.comSigned-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
parent 65543b33
...@@ -85,7 +85,7 @@ static void nps400_irq_eoi_global(struct irq_data *irqd) ...@@ -85,7 +85,7 @@ static void nps400_irq_eoi_global(struct irq_data *irqd)
nps_ack_gic(); nps_ack_gic();
} }
static void nps400_irq_eoi(struct irq_data *irqd) static void nps400_irq_ack(struct irq_data *irqd)
{ {
unsigned int __maybe_unused irq = irqd_to_hwirq(irqd); unsigned int __maybe_unused irq = irqd_to_hwirq(irqd);
...@@ -103,7 +103,7 @@ static struct irq_chip nps400_irq_chip_percpu = { ...@@ -103,7 +103,7 @@ static struct irq_chip nps400_irq_chip_percpu = {
.name = "NPS400 IC", .name = "NPS400 IC",
.irq_mask = nps400_irq_mask, .irq_mask = nps400_irq_mask,
.irq_unmask = nps400_irq_unmask, .irq_unmask = nps400_irq_unmask,
.irq_eoi = nps400_irq_eoi, .irq_ack = nps400_irq_ack,
}; };
static int nps400_irq_map(struct irq_domain *d, unsigned int virq, static int nps400_irq_map(struct irq_domain *d, unsigned int virq,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment