Commit c0d51c67 authored by Gary N. Spiess's avatar Gary N. Spiess Committed by Jeff Garzik

[PATCH] natsemi long cable fix

This is a minor modification to the previous patch submission that does
not assume the default contents of the DSPCFG register are zero.

When used with Revision D of the DP83815, the "Recommended Registers
Configuration" from page 78 of the DP83815 data sheet is not entirely
compatible with the driver's "short cable patch".  When the DSPCFG
register is written with the value suggested in the document, then
do_cable_magic() can't read the DSP coefficient and determines that all
cables attached to the DP83815D are 'short', regardless of actual
length.  Short cables (< 30m) cause do_cable_magic to enable additional
attenuation to reduce CRC and idle errors.  If the extra attenuation is
unintentionally enabled for long cables (> 50m?), they will not operate
properly.  The National Semiconductor driver, 'dp83815.c' from
http://www.national.com/appinfo/networks/files/linux_2_4.tar.gz was used
as a basis for this modification.
Signed-off-by: default avatarJeff Garzik <jgarzik@pobox.com>
parent 09c4fa67
...@@ -441,6 +441,7 @@ enum register_offsets { ...@@ -441,6 +441,7 @@ enum register_offsets {
#define DSPCFG_VAL 0x5040 #define DSPCFG_VAL 0x5040
#define SDCFG_VAL 0x008c /* set voltage thresholds for Signal Detect */ #define SDCFG_VAL 0x008c /* set voltage thresholds for Signal Detect */
#define DSPCFG_LOCK 0x20 /* coefficient lock bit in DSPCFG */ #define DSPCFG_LOCK 0x20 /* coefficient lock bit in DSPCFG */
#define DSPCFG_COEF 0x1000 /* see coefficient (in TSTDAT) bit in DSPCFG */
#define TSTDAT_FIXED 0xe8 /* magic number for bad coefficients */ #define TSTDAT_FIXED 0xe8 /* magic number for bad coefficients */
/* misc PCI space registers */ /* misc PCI space registers */
...@@ -1243,7 +1244,8 @@ static void init_phy_fixup(struct net_device *dev) ...@@ -1243,7 +1244,8 @@ static void init_phy_fixup(struct net_device *dev)
writew(1, ioaddr + PGSEL); writew(1, ioaddr + PGSEL);
writew(PMDCSR_VAL, ioaddr + PMDCSR); writew(PMDCSR_VAL, ioaddr + PMDCSR);
writew(TSTDAT_VAL, ioaddr + TSTDAT); writew(TSTDAT_VAL, ioaddr + TSTDAT);
np->dspcfg = DSPCFG_VAL; np->dspcfg = (np->srr <= SRR_DP83815_C)?
DSPCFG_VAL : (DSPCFG_COEF | readw(ioaddr + DSPCFG));
writew(np->dspcfg, ioaddr + DSPCFG); writew(np->dspcfg, ioaddr + DSPCFG);
writew(SDCFG_VAL, ioaddr + SDCFG); writew(SDCFG_VAL, ioaddr + SDCFG);
writew(0, ioaddr + PGSEL); writew(0, ioaddr + PGSEL);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment