Commit c2f3f3a2 authored by françois romieu's avatar françois romieu Committed by David S. Miller

sis190: use an adequate phy list entry as a fallback

When sis190 driver is trying to get default phy, if it doesn't find home
or lan phy, it falls back to the first phy in the phy list but list_entry()
points to a bogus entry. list_first_entry() should be used instead.
Signed-off-by: default avatarArnaud Patard <apatard@mandriva.com>
Acked-off-by: default avatarFrancois Romieu <romieu@fr.zoreil.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent fb1001f3
...@@ -1281,7 +1281,7 @@ static u16 sis190_default_phy(struct net_device *dev) ...@@ -1281,7 +1281,7 @@ static u16 sis190_default_phy(struct net_device *dev)
else if (phy_lan) else if (phy_lan)
phy_default = phy_lan; phy_default = phy_lan;
else else
phy_default = list_entry(&tp->first_phy, phy_default = list_first_entry(&tp->first_phy,
struct sis190_phy, list); struct sis190_phy, list);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment