Commit c3aa6556 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman

greybus: operation: use the bundle struct device instead of the connector

We are removing struct device from the gb_connection structure in the
near future.  The gb_bundle structure's struct device should be used as
a replacement.

This patch moves the operation code to use to use the bundle pointer
instead of the connection pointer when printing out error messages.
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@google.com>
Reviewed-by: default avatarAlex Elder <elder@linaro.org>
parent dfdc6e12
...@@ -227,7 +227,7 @@ static void gb_operation_request_handle(struct gb_operation *operation) ...@@ -227,7 +227,7 @@ static void gb_operation_request_handle(struct gb_operation *operation)
if (protocol->request_recv) { if (protocol->request_recv) {
status = protocol->request_recv(operation->type, operation); status = protocol->request_recv(operation->type, operation);
} else { } else {
dev_err(&operation->connection->dev, dev_err(&operation->connection->bundle->dev,
"unexpected incoming request type 0x%02hhx\n", "unexpected incoming request type 0x%02hhx\n",
operation->type); operation->type);
...@@ -236,7 +236,7 @@ static void gb_operation_request_handle(struct gb_operation *operation) ...@@ -236,7 +236,7 @@ static void gb_operation_request_handle(struct gb_operation *operation)
ret = gb_operation_response_send(operation, status); ret = gb_operation_response_send(operation, status);
if (ret) { if (ret) {
dev_err(&operation->connection->dev, dev_err(&operation->connection->bundle->dev,
"failed to send response %d for type 0x%02hhx: %d\n", "failed to send response %d for type 0x%02hhx: %d\n",
status, operation->type, ret); status, operation->type, ret);
return; return;
...@@ -743,7 +743,7 @@ static int gb_operation_response_send(struct gb_operation *operation, ...@@ -743,7 +743,7 @@ static int gb_operation_response_send(struct gb_operation *operation,
/* Record the result */ /* Record the result */
if (!gb_operation_result_set(operation, errno)) { if (!gb_operation_result_set(operation, errno)) {
dev_err(&connection->dev, "request result already set\n"); dev_err(&connection->bundle->dev, "request result already set\n");
return -EIO; /* Shouldn't happen */ return -EIO; /* Shouldn't happen */
} }
...@@ -795,7 +795,7 @@ void greybus_message_sent(struct greybus_host_device *hd, ...@@ -795,7 +795,7 @@ void greybus_message_sent(struct greybus_host_device *hd,
*/ */
if (message == operation->response) { if (message == operation->response) {
if (status) { if (status) {
dev_err(&connection->dev, dev_err(&connection->bundle->dev,
"error sending response type 0x%02hhx: %d\n", "error sending response type 0x%02hhx: %d\n",
operation->type, status); operation->type, status);
} }
...@@ -827,7 +827,8 @@ static void gb_connection_recv_request(struct gb_connection *connection, ...@@ -827,7 +827,8 @@ static void gb_connection_recv_request(struct gb_connection *connection,
operation = gb_operation_create_incoming(connection, operation_id, operation = gb_operation_create_incoming(connection, operation_id,
type, data, size); type, data, size);
if (!operation) { if (!operation) {
dev_err(&connection->dev, "can't create incoming operation\n"); dev_err(&connection->bundle->dev,
"can't create incoming operation\n");
return; return;
} }
...@@ -864,15 +865,15 @@ static void gb_connection_recv_response(struct gb_connection *connection, ...@@ -864,15 +865,15 @@ static void gb_connection_recv_response(struct gb_connection *connection,
operation = gb_operation_find_outgoing(connection, operation_id); operation = gb_operation_find_outgoing(connection, operation_id);
if (!operation) { if (!operation) {
dev_err(&connection->dev, "unexpected response 0x%04hx received\n", dev_err(&connection->bundle->dev,
operation_id); "unexpected response 0x%04hx received\n", operation_id);
return; return;
} }
message = operation->response; message = operation->response;
message_size = sizeof(*message->header) + message->payload_size; message_size = sizeof(*message->header) + message->payload_size;
if (!errno && size != message_size) { if (!errno && size != message_size) {
dev_err(&connection->dev, dev_err(&connection->bundle->dev,
"malformed response of type 0x%02hhx received (%zu != %zu)\n", "malformed response of type 0x%02hhx received (%zu != %zu)\n",
message->header->type, size, message_size); message->header->type, size, message_size);
errno = -EMSGSIZE; errno = -EMSGSIZE;
...@@ -901,17 +902,17 @@ void gb_connection_recv(struct gb_connection *connection, ...@@ -901,17 +902,17 @@ void gb_connection_recv(struct gb_connection *connection,
void *data, size_t size) void *data, size_t size)
{ {
struct gb_operation_msg_hdr header; struct gb_operation_msg_hdr header;
struct device *dev = &connection->bundle->dev;
size_t msg_size; size_t msg_size;
u16 operation_id; u16 operation_id;
if (connection->state != GB_CONNECTION_STATE_ENABLED) { if (connection->state != GB_CONNECTION_STATE_ENABLED) {
dev_warn(&connection->dev, "dropping %zu received bytes\n", dev_warn(dev, "dropping %zu received bytes\n", size);
size);
return; return;
} }
if (size < sizeof(header)) { if (size < sizeof(header)) {
dev_err(&connection->dev, "short message received\n"); dev_err(dev, "short message received\n");
return; return;
} }
...@@ -919,7 +920,7 @@ void gb_connection_recv(struct gb_connection *connection, ...@@ -919,7 +920,7 @@ void gb_connection_recv(struct gb_connection *connection,
memcpy(&header, data, sizeof(header)); memcpy(&header, data, sizeof(header));
msg_size = le16_to_cpu(header.size); msg_size = le16_to_cpu(header.size);
if (size < msg_size) { if (size < msg_size) {
dev_err(&connection->dev, dev_err(dev,
"incomplete message 0x%04hx of type 0x%02hhx received (%zu < %zu)\n", "incomplete message 0x%04hx of type 0x%02hhx received (%zu < %zu)\n",
le16_to_cpu(header.operation_id), header.type, size, le16_to_cpu(header.operation_id), header.type, size,
msg_size); msg_size);
...@@ -1029,7 +1030,7 @@ int gb_operation_sync_timeout(struct gb_connection *connection, int type, ...@@ -1029,7 +1030,7 @@ int gb_operation_sync_timeout(struct gb_connection *connection, int type,
ret = gb_operation_request_send_sync_timeout(operation, timeout); ret = gb_operation_request_send_sync_timeout(operation, timeout);
if (ret) { if (ret) {
dev_err(&connection->dev, dev_err(&connection->bundle->dev,
"synchronous operation of type 0x%02hhx failed: %d\n", "synchronous operation of type 0x%02hhx failed: %d\n",
type, ret); type, ret);
} else { } else {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment