Commit c4c59b95 authored by Qiushi Wu's avatar Qiushi Wu Committed by Mark Brown

ASoC: img: Fix a reference count leak in img_i2s_in_set_fmt

pm_runtime_get_sync() increments the runtime PM usage counter even
when it returns an error code, causing incorrect ref count if
pm_runtime_put_noidle() is not called in error handling paths.
Thus call pm_runtime_put_noidle() if pm_runtime_get_sync() fails.
Signed-off-by: default avatarQiushi Wu <wu000273@umn.edu>
Link: https://lore.kernel.org/r/20200614033749.2975-1-wu000273@umn.eduSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent c9015a17
...@@ -343,8 +343,10 @@ static int img_i2s_in_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) ...@@ -343,8 +343,10 @@ static int img_i2s_in_set_fmt(struct snd_soc_dai *dai, unsigned int fmt)
chan_control_mask = IMG_I2S_IN_CH_CTL_CLK_TRANS_MASK; chan_control_mask = IMG_I2S_IN_CH_CTL_CLK_TRANS_MASK;
ret = pm_runtime_get_sync(i2s->dev); ret = pm_runtime_get_sync(i2s->dev);
if (ret < 0) if (ret < 0) {
pm_runtime_put_noidle(i2s->dev);
return ret; return ret;
}
for (i = 0; i < i2s->active_channels; i++) for (i = 0; i < i2s->active_channels; i++)
img_i2s_in_ch_disable(i2s, i); img_i2s_in_ch_disable(i2s, i);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment