Commit c7bf1fb7 authored by Nicolai Stange's avatar Nicolai Stange Committed by Kalle Valo

libertas: don't exit from lbs_ibss_join_existing() with RCU read lock held

Commit e5e884b4 ("libertas: Fix two buffer overflows at parsing bss
descriptor") introduced a bounds check on the number of supplied rates to
lbs_ibss_join_existing().

Unfortunately, it introduced a return path from within a RCU read side
critical section without a corresponding rcu_read_unlock(). Fix this.

Fixes: e5e884b4 ("libertas: Fix two buffer overflows at parsing bss descriptor")
Signed-off-by: default avatarNicolai Stange <nstange@suse.de>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent b70261a2
......@@ -1785,6 +1785,7 @@ static int lbs_ibss_join_existing(struct lbs_private *priv,
rates_max = rates_eid[1];
if (rates_max > MAX_RATES) {
lbs_deb_join("invalid rates");
rcu_read_unlock();
goto out;
}
rates = cmd.bss.rates;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment