Commit cc0be81f authored by Julia Lawall's avatar Julia Lawall Committed by Greg Kroah-Hartman

staging: tidspbridge: use safer test on the result of find_first_zero_bit

Find_first_zero_bit considers BITS_PER_LONG bits at a time, and thus may
return a larger number than the maximum position argument if that position
is not a multiple of BITS_PER_LONG.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e1,e2,e3;
statement S1,S2;
@@

e1 = find_first_zero_bit(e2,e3)
...
if (e1
- ==
+ >=
  e3)
S1 else S2
// </smpl>
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent cee49b3c
...@@ -935,7 +935,7 @@ int node_connect(struct node_object *node1, u32 stream1, ...@@ -935,7 +935,7 @@ int node_connect(struct node_object *node1, u32 stream1,
node2_type == NODE_DAISSOCKET)) { node2_type == NODE_DAISSOCKET)) {
/* Find available pipe */ /* Find available pipe */
pipe_id = find_first_zero_bit(hnode_mgr->pipe_map, MAXPIPES); pipe_id = find_first_zero_bit(hnode_mgr->pipe_map, MAXPIPES);
if (pipe_id == MAXPIPES) { if (pipe_id >= MAXPIPES) {
status = -ECONNREFUSED; status = -ECONNREFUSED;
goto out_unlock; goto out_unlock;
} }
...@@ -1008,7 +1008,7 @@ int node_connect(struct node_object *node1, u32 stream1, ...@@ -1008,7 +1008,7 @@ int node_connect(struct node_object *node1, u32 stream1,
status = -EINVAL; status = -EINVAL;
goto out_unlock; goto out_unlock;
} }
if (chnl_id == CHNL_MAXCHANNELS) { if (chnl_id >= CHNL_MAXCHANNELS) {
status = -ECONNREFUSED; status = -ECONNREFUSED;
goto out_unlock; goto out_unlock;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment