Commit cda9cc59 authored by Yunlei He's avatar Yunlei He Committed by Jaegeuk Kim

f2fs: report error if quota off error during umount

Now, we depend on fsck to ensure quota file data is ok,
so we scan whole partition if checkpoint without umount
flag. It's same for quota off error case, which may make
quota file data inconsistent.

generic/019 reports below error:

 __quota_error: 1160 callbacks suppressed
 Quota error (device zram1): write_blk: dquota write failed
 Quota error (device zram1): qtree_write_dquot: Error -28 occurred while creating quota
 Quota error (device zram1): write_blk: dquota write failed
 Quota error (device zram1): qtree_write_dquot: Error -28 occurred while creating quota
 Quota error (device zram1): write_blk: dquota write failed
 Quota error (device zram1): qtree_write_dquot: Error -28 occurred while creating quota
 Quota error (device zram1): write_blk: dquota write failed
 Quota error (device zram1): qtree_write_dquot: Error -28 occurred while creating quota
 Quota error (device zram1): write_blk: dquota write failed
 Quota error (device zram1): qtree_write_dquot: Error -28 occurred while creating quota
 VFS: Busy inodes after unmount of zram1. Self-destruct in 5 seconds.  Have a nice day...

If we failed in below path due to fail to write dquot block, we will miss
to release quota inode, fix it.

- f2fs_put_super
 - f2fs_quota_off_umount
  - f2fs_quota_off
   - f2fs_quota_sync   <-- failed
   - dquot_quota_off   <-- missed to call
Signed-off-by: default avatarYunlei He <heyunlei@huawei.com>
Signed-off-by: default avatarChao Yu <yuchao0@huawei.com>
Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
parent 5ce80586
...@@ -1844,7 +1844,9 @@ static int f2fs_quota_off(struct super_block *sb, int type) ...@@ -1844,7 +1844,9 @@ static int f2fs_quota_off(struct super_block *sb, int type)
if (!inode || !igrab(inode)) if (!inode || !igrab(inode))
return dquot_quota_off(sb, type); return dquot_quota_off(sb, type);
f2fs_quota_sync(sb, type); err = f2fs_quota_sync(sb, type);
if (err)
goto out_put;
err = dquot_quota_off(sb, type); err = dquot_quota_off(sb, type);
if (err || f2fs_sb_has_quota_ino(sb)) if (err || f2fs_sb_has_quota_ino(sb))
...@@ -1863,9 +1865,20 @@ static int f2fs_quota_off(struct super_block *sb, int type) ...@@ -1863,9 +1865,20 @@ static int f2fs_quota_off(struct super_block *sb, int type)
void f2fs_quota_off_umount(struct super_block *sb) void f2fs_quota_off_umount(struct super_block *sb)
{ {
int type; int type;
int err;
for (type = 0; type < MAXQUOTAS; type++) {
err = f2fs_quota_off(sb, type);
if (err) {
int ret = dquot_quota_off(sb, type);
for (type = 0; type < MAXQUOTAS; type++) f2fs_msg(sb, KERN_ERR,
f2fs_quota_off(sb, type); "Fail to turn off disk quota "
"(type: %d, err: %d, ret:%d), Please "
"run fsck to fix it.", type, err, ret);
set_sbi_flag(F2FS_SB(sb), SBI_NEED_FSCK);
}
}
} }
static int f2fs_get_projid(struct inode *inode, kprojid_t *projid) static int f2fs_get_projid(struct inode *inode, kprojid_t *projid)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment