Commit d00e708c authored by Atsushi Nemoto's avatar Atsushi Nemoto Committed by Herbert Xu

[CRYPTO] khazad: Use 32-bit reads on key

On 64-bit platform, reading 64-bit keys (which is supposed to be
32-bit aligned) at a time will result in unaligned access.
Signed-off-by: default avatarAtsushi Nemoto <anemo@mba.ocn.ne.jp>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent fcc18e83
...@@ -758,7 +758,7 @@ static int khazad_setkey(void *ctx_arg, const u8 *in_key, ...@@ -758,7 +758,7 @@ static int khazad_setkey(void *ctx_arg, const u8 *in_key,
unsigned int key_len, u32 *flags) unsigned int key_len, u32 *flags)
{ {
struct khazad_ctx *ctx = ctx_arg; struct khazad_ctx *ctx = ctx_arg;
const __be64 *key = (const __be64 *)in_key; const __be32 *key = (const __be32 *)in_key;
int r; int r;
const u64 *S = T7; const u64 *S = T7;
u64 K2, K1; u64 K2, K1;
...@@ -769,8 +769,9 @@ static int khazad_setkey(void *ctx_arg, const u8 *in_key, ...@@ -769,8 +769,9 @@ static int khazad_setkey(void *ctx_arg, const u8 *in_key,
return -EINVAL; return -EINVAL;
} }
K2 = be64_to_cpu(key[0]); /* key is supposed to be 32-bit aligned */
K1 = be64_to_cpu(key[1]); K2 = ((u64)be32_to_cpu(key[0]) << 32) | be32_to_cpu(key[1]);
K1 = ((u64)be32_to_cpu(key[2]) << 32) | be32_to_cpu(key[3]);
/* setup the encrypt key */ /* setup the encrypt key */
for (r = 0; r <= KHAZAD_ROUNDS; r++) { for (r = 0; r <= KHAZAD_ROUNDS; r++) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment