Commit d1746d1e authored by Petr Machata's avatar Petr Machata Committed by David S. Miller

net: flow_dissector: Wrap unionized VLAN fields in a struct

In commit a82055af ("netfilter: nft_payload: add VLAN offload
support"), VLAN fields in struct flow_dissector_key_vlan were unionized
with the intention of introducing another field that covered the whole TCI
header. However without a wrapping struct the subfields end up sharing the
same bits. As a result, "tc filter add ... flower vlan_id 14" specifies not
only vlan_id, but also vlan_priority.

Fix by wrapping the individual VLAN fields in a struct.

Fixes: a82055af ("netfilter: nft_payload: add VLAN offload support")
Signed-off-by: default avatarPetr Machata <petrm@mellanox.com>
Reviewed-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4bbb02f1
...@@ -49,9 +49,11 @@ struct flow_dissector_key_tags { ...@@ -49,9 +49,11 @@ struct flow_dissector_key_tags {
struct flow_dissector_key_vlan { struct flow_dissector_key_vlan {
union { union {
u16 vlan_id:12, struct {
vlan_dei:1, u16 vlan_id:12,
vlan_priority:3; vlan_dei:1,
vlan_priority:3;
};
__be16 vlan_tci; __be16 vlan_tci;
}; };
__be16 vlan_tpid; __be16 vlan_tpid;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment