Commit d197f798 authored by Matthias Kaehlcke's avatar Matthias Kaehlcke Committed by Daniel Lezcano

clocksource/drivers/arm_arch_timer: Fix mem frame loop initialization

The loop to find the best memory frame in arch_timer_mem_acpi_init()
initializes the loop counter with itself ('i = i'), which is suspicious
in the first place and pointed out by clang. The loop condition is
'i < timer_count' and a prior for loop exits when 'i' reaches
'timer_count', therefore the second loop is never executed.

Initialize the loop counter with 0 to iterate over all timers, which
supposedly was the intention before the typo monster attacked.

Fixes: c2743a36 ("clocksource: arm_arch_timer: add GTDT support for memory-mapped timer")
Signed-off-by: default avatarMatthias Kaehlcke <mka@chromium.org>
Reported-by: default avatarArd Biesheuvel <ard.biesheuvel@linaro.org>
Acked-by: default avatarMark Rutland <mark.rutland@arm.com>
Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
parent 34f41c03
...@@ -1440,7 +1440,7 @@ static int __init arch_timer_mem_acpi_init(int platform_timer_count) ...@@ -1440,7 +1440,7 @@ static int __init arch_timer_mem_acpi_init(int platform_timer_count)
* While unlikely, it's theoretically possible that none of the frames * While unlikely, it's theoretically possible that none of the frames
* in a timer expose the combination of feature we want. * in a timer expose the combination of feature we want.
*/ */
for (i = i; i < timer_count; i++) { for (i = 0; i < timer_count; i++) {
timer = &timers[i]; timer = &timers[i];
frame = arch_timer_mem_find_best_frame(timer); frame = arch_timer_mem_find_best_frame(timer);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment