Commit d1bcf17c authored by Changbin Du's avatar Changbin Du Committed by Arnaldo Carvalho de Melo

perf ftrace: Add support for trace option funcgraph-irqs

This adds an option '--graph-opts noirqs' to filter out functions executed
in irq context.
Signed-off-by: default avatarChangbin Du <changbin.du@gmail.com>
Acked-by: default avatarNamhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt (VMware) <rostedt@goodmis.org>
Link: http://lore.kernel.org/lkml/20200808023141.14227-11-changbin.du@gmail.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 38988f2e
...@@ -104,6 +104,7 @@ OPTIONS ...@@ -104,6 +104,7 @@ OPTIONS
--graph-opts:: --graph-opts::
List of options allowed to set: List of options allowed to set:
nosleep-time - Measure on-CPU time only for function_graph tracer. nosleep-time - Measure on-CPU time only for function_graph tracer.
noirqs - Ignore functions that happen inside interrupt.
SEE ALSO SEE ALSO
-------- --------
......
...@@ -45,6 +45,7 @@ struct perf_ftrace { ...@@ -45,6 +45,7 @@ struct perf_ftrace {
bool inherit; bool inherit;
int func_stack_trace; int func_stack_trace;
int graph_nosleep_time; int graph_nosleep_time;
int graph_noirqs;
}; };
struct filter_entry { struct filter_entry {
...@@ -207,6 +208,7 @@ static void reset_tracing_options(struct perf_ftrace *ftrace __maybe_unused) ...@@ -207,6 +208,7 @@ static void reset_tracing_options(struct perf_ftrace *ftrace __maybe_unused)
write_tracing_option_file("function-fork", "0"); write_tracing_option_file("function-fork", "0");
write_tracing_option_file("func_stack_trace", "0"); write_tracing_option_file("func_stack_trace", "0");
write_tracing_option_file("sleep-time", "1"); write_tracing_option_file("sleep-time", "1");
write_tracing_option_file("funcgraph-irqs", "1");
} }
static int reset_tracing_files(struct perf_ftrace *ftrace __maybe_unused) static int reset_tracing_files(struct perf_ftrace *ftrace __maybe_unused)
...@@ -399,6 +401,17 @@ static int set_tracing_sleep_time(struct perf_ftrace *ftrace) ...@@ -399,6 +401,17 @@ static int set_tracing_sleep_time(struct perf_ftrace *ftrace)
return 0; return 0;
} }
static int set_tracing_funcgraph_irqs(struct perf_ftrace *ftrace)
{
if (!ftrace->graph_noirqs)
return 0;
if (write_tracing_option_file("funcgraph-irqs", "0") < 0)
return -1;
return 0;
}
static int __cmd_ftrace(struct perf_ftrace *ftrace, int argc, const char **argv) static int __cmd_ftrace(struct perf_ftrace *ftrace, int argc, const char **argv)
{ {
char *trace_file; char *trace_file;
...@@ -483,6 +496,11 @@ static int __cmd_ftrace(struct perf_ftrace *ftrace, int argc, const char **argv) ...@@ -483,6 +496,11 @@ static int __cmd_ftrace(struct perf_ftrace *ftrace, int argc, const char **argv)
goto out_reset; goto out_reset;
} }
if (set_tracing_funcgraph_irqs(ftrace) < 0) {
pr_err("failed to set tracing option funcgraph-irqs\n");
goto out_reset;
}
if (write_tracing_file("current_tracer", ftrace->tracer) < 0) { if (write_tracing_file("current_tracer", ftrace->tracer) < 0) {
pr_err("failed to set current_tracer to %s\n", ftrace->tracer); pr_err("failed to set current_tracer to %s\n", ftrace->tracer);
goto out_reset; goto out_reset;
...@@ -662,6 +680,7 @@ static int parse_graph_tracer_opts(const struct option *opt, ...@@ -662,6 +680,7 @@ static int parse_graph_tracer_opts(const struct option *opt,
struct perf_ftrace *ftrace = (struct perf_ftrace *) opt->value; struct perf_ftrace *ftrace = (struct perf_ftrace *) opt->value;
struct sublevel_option graph_tracer_opts[] = { struct sublevel_option graph_tracer_opts[] = {
{ .name = "nosleep-time", .value_ptr = &ftrace->graph_nosleep_time }, { .name = "nosleep-time", .value_ptr = &ftrace->graph_nosleep_time },
{ .name = "noirqs", .value_ptr = &ftrace->graph_noirqs },
{ .name = NULL, } { .name = NULL, }
}; };
...@@ -733,7 +752,7 @@ int cmd_ftrace(int argc, const char **argv) ...@@ -733,7 +752,7 @@ int cmd_ftrace(int argc, const char **argv)
OPT_INTEGER('D', "graph-depth", &ftrace.graph_depth, OPT_INTEGER('D', "graph-depth", &ftrace.graph_depth,
"Max depth for function graph tracer"), "Max depth for function graph tracer"),
OPT_CALLBACK(0, "graph-opts", &ftrace, "options", OPT_CALLBACK(0, "graph-opts", &ftrace, "options",
"graph tracer options, available options: nosleep-time", "graph tracer options, available options: nosleep-time,noirqs",
parse_graph_tracer_opts), parse_graph_tracer_opts),
OPT_CALLBACK('m', "buffer-size", &ftrace.percpu_buffer_size, "size", OPT_CALLBACK('m', "buffer-size", &ftrace.percpu_buffer_size, "size",
"size of per cpu buffer", parse_buffer_size), "size of per cpu buffer", parse_buffer_size),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment