Commit d32b9a81 authored by Feras Daoud's avatar Feras Daoud Committed by Doug Ledford

IB/ipoib: Add detailed error message to dev_queue_xmit call

Add a detailed return code to dev_queue_xmit function when
calling to requeue packet via __skb_dequeue.
Signed-off-by: default avatarFeras Daoud <ferasda@mellanox.com>
Signed-off-by: default avatarErez Shitrit <erezsh@mellanox.com>
Reviewed-by: default avatarYuval Shaia <yuval.shaia@oracle.com>
Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 89a3987a
...@@ -1015,9 +1015,10 @@ static int ipoib_cm_rep_handler(struct ib_cm_id *cm_id, struct ib_cm_event *even ...@@ -1015,9 +1015,10 @@ static int ipoib_cm_rep_handler(struct ib_cm_id *cm_id, struct ib_cm_event *even
while ((skb = __skb_dequeue(&skqueue))) { while ((skb = __skb_dequeue(&skqueue))) {
skb->dev = p->dev; skb->dev = p->dev;
if (dev_queue_xmit(skb)) ret = dev_queue_xmit(skb);
ipoib_warn(priv, "dev_queue_xmit failed " if (ret)
"to requeue packet\n"); ipoib_warn(priv, "%s:dev_queue_xmit failed to re-queue packet, ret:%d\n",
__func__, ret);
} }
ret = ib_send_cm_rtu(cm_id, NULL, 0); ret = ib_send_cm_rtu(cm_id, NULL, 0);
......
...@@ -843,10 +843,12 @@ static void path_rec_completion(int status, ...@@ -843,10 +843,12 @@ static void path_rec_completion(int status,
ipoib_put_ah(old_ah); ipoib_put_ah(old_ah);
while ((skb = __skb_dequeue(&skqueue))) { while ((skb = __skb_dequeue(&skqueue))) {
int ret;
skb->dev = dev; skb->dev = dev;
if (dev_queue_xmit(skb)) ret = dev_queue_xmit(skb);
ipoib_warn(priv, "dev_queue_xmit failed " if (ret)
"to requeue packet\n"); ipoib_warn(priv, "%s: dev_queue_xmit failed to re-queue packet, ret:%d\n",
__func__, ret);
} }
} }
......
...@@ -314,9 +314,11 @@ static int ipoib_mcast_join_finish(struct ipoib_mcast *mcast, ...@@ -314,9 +314,11 @@ static int ipoib_mcast_join_finish(struct ipoib_mcast *mcast,
netif_tx_unlock_bh(dev); netif_tx_unlock_bh(dev);
skb->dev = dev; skb->dev = dev;
if (dev_queue_xmit(skb))
ipoib_warn(priv, "dev_queue_xmit failed to requeue packet\n");
ret = dev_queue_xmit(skb);
if (ret)
ipoib_warn(priv, "%s:dev_queue_xmit failed to re-queue packet, ret:%d\n",
__func__, ret);
netif_tx_lock_bh(dev); netif_tx_lock_bh(dev);
} }
netif_tx_unlock_bh(dev); netif_tx_unlock_bh(dev);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment