Commit d33dcb9e authored by Peter Oruba's avatar Peter Oruba Committed by Ingo Molnar

x86: Microcode patch loader style corrections

Style corrections to main microcode module.
Signed-off-by: default avatarPeter Oruba <peter.oruba@amd.com>
Cc: Peter Oruba <peter.oruba@amd.com>
Cc: Tigran Aivazian <tigran@aivazian.fsnet.co.uk>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent 34a1b9fc
...@@ -55,8 +55,8 @@ ...@@ -55,8 +55,8 @@
* in a single CPU package. * in a single CPU package.
* 1.10 28 Feb 2002 Asit K Mallick <asit.k.mallick@intel.com> and * 1.10 28 Feb 2002 Asit K Mallick <asit.k.mallick@intel.com> and
* Tigran Aivazian <tigran@veritas.com>, * Tigran Aivazian <tigran@veritas.com>,
* Serialize updates as required on HT processors due to speculative * Serialize updates as required on HT processors due to
* nature of implementation. * speculative nature of implementation.
* 1.11 22 Mar 2002 Tigran Aivazian <tigran@veritas.com> * 1.11 22 Mar 2002 Tigran Aivazian <tigran@veritas.com>
* Fix the panic when writing zero-length microcode chunk. * Fix the panic when writing zero-length microcode chunk.
* 1.12 29 Sep 2003 Nitin Kamble <nitin.a.kamble@intel.com>, * 1.12 29 Sep 2003 Nitin Kamble <nitin.a.kamble@intel.com>,
...@@ -71,7 +71,7 @@ ...@@ -71,7 +71,7 @@
* Thanks to Stuart Swales for pointing out this bug. * Thanks to Stuart Swales for pointing out this bug.
*/ */
//#define DEBUG /* pr_debug */ /*#define DEBUG pr_debug */
#include <linux/capability.h> #include <linux/capability.h>
#include <linux/kernel.h> #include <linux/kernel.h>
#include <linux/init.h> #include <linux/init.h>
...@@ -116,7 +116,7 @@ EXPORT_SYMBOL_GPL(user_buffer); ...@@ -116,7 +116,7 @@ EXPORT_SYMBOL_GPL(user_buffer);
unsigned int user_buffer_size; /* it's size */ unsigned int user_buffer_size; /* it's size */
EXPORT_SYMBOL_GPL(user_buffer_size); EXPORT_SYMBOL_GPL(user_buffer_size);
static int do_microcode_update (void) static int do_microcode_update(void)
{ {
long cursor = 0; long cursor = 0;
int error = 0; int error = 0;
...@@ -158,18 +158,20 @@ static int do_microcode_update (void) ...@@ -158,18 +158,20 @@ static int do_microcode_update (void)
return error; return error;
} }
static int microcode_open (struct inode *unused1, struct file *unused2) static int microcode_open(struct inode *unused1, struct file *unused2)
{ {
cycle_kernel_lock(); cycle_kernel_lock();
return capable(CAP_SYS_RAWIO) ? 0 : -EPERM; return capable(CAP_SYS_RAWIO) ? 0 : -EPERM;
} }
static ssize_t microcode_write (struct file *file, const char __user *buf, size_t len, loff_t *ppos) static ssize_t microcode_write(struct file *file, const char __user *buf,
size_t len, loff_t *ppos)
{ {
ssize_t ret; ssize_t ret;
if ((len >> PAGE_SHIFT) > num_physpages) { if ((len >> PAGE_SHIFT) > num_physpages) {
printk(KERN_ERR "microcode: too much data (max %ld pages)\n", num_physpages); printk(KERN_ERR "microcode: too much data (max %ld pages)\n",
num_physpages);
return -EINVAL; return -EINVAL;
} }
...@@ -201,7 +203,7 @@ static struct miscdevice microcode_dev = { ...@@ -201,7 +203,7 @@ static struct miscdevice microcode_dev = {
.fops = &microcode_fops, .fops = &microcode_fops,
}; };
static int __init microcode_dev_init (void) static int __init microcode_dev_init(void)
{ {
int error; int error;
...@@ -216,7 +218,7 @@ static int __init microcode_dev_init (void) ...@@ -216,7 +218,7 @@ static int __init microcode_dev_init (void)
return 0; return 0;
} }
static void microcode_dev_exit (void) static void microcode_dev_exit(void)
{ {
misc_deregister(&microcode_dev); misc_deregister(&microcode_dev);
} }
...@@ -224,7 +226,7 @@ static void microcode_dev_exit (void) ...@@ -224,7 +226,7 @@ static void microcode_dev_exit (void)
MODULE_ALIAS_MISCDEV(MICROCODE_MINOR); MODULE_ALIAS_MISCDEV(MICROCODE_MINOR);
#else #else
#define microcode_dev_init() 0 #define microcode_dev_init() 0
#define microcode_dev_exit() do { } while(0) #define microcode_dev_exit() do { } while (0)
#endif #endif
/* fake device for request_firmware */ /* fake device for request_firmware */
...@@ -451,7 +453,7 @@ int microcode_init(void *opaque, struct module *module) ...@@ -451,7 +453,7 @@ int microcode_init(void *opaque, struct module *module)
} }
EXPORT_SYMBOL_GPL(microcode_init); EXPORT_SYMBOL_GPL(microcode_init);
void __exit microcode_exit (void) void __exit microcode_exit(void)
{ {
microcode_dev_exit(); microcode_dev_exit();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment