Commit d489412c authored by Brian Norris's avatar Brian Norris Committed by Greg Kroah-Hartman

i2c: cros-ec-tunnel: Fix usage of cros_ec_cmd_xfer()

commit 4d01d880 upstream.

cros_ec_cmd_xfer returns success status if the command transport
completes successfully, but the execution result is incorrectly ignored.
In many cases, the execution result is assumed to be successful, leading
to ignored errors and operating on uninitialized data.

We've recently introduced the cros_ec_cmd_xfer_status() helper to avoid these
problems. Let's use it.

[Regarding the 'Fixes' tag; there is significant refactoring since the driver's
introduction, but the underlying logical error exists throughout I believe]

Fixes: 9d230c9e ("i2c: ChromeOS EC tunnel driver")
Signed-off-by: default avatarBrian Norris <briannorris@chromium.org>
Reviewed-by: default avatarJavier Martinez Canillas <javier@osg.samsung.com>
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d91c348e
...@@ -215,7 +215,7 @@ static int ec_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg i2c_msgs[], ...@@ -215,7 +215,7 @@ static int ec_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg i2c_msgs[],
msg->outsize = request_len; msg->outsize = request_len;
msg->insize = response_len; msg->insize = response_len;
result = cros_ec_cmd_xfer(bus->ec, msg); result = cros_ec_cmd_xfer_status(bus->ec, msg);
if (result < 0) { if (result < 0) {
dev_err(dev, "Error transferring EC i2c message %d\n", result); dev_err(dev, "Error transferring EC i2c message %d\n", result);
goto exit; goto exit;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment