[PATCH] USB: switching microtek to usb_kill_urb

Am Dienstag, 31. August 2004 17:41 schrieb Alan Stern:
> On Tue, 31 Aug 2004, Oliver Neukum wrote:
>
> Alan Stern
>
>
>
>
> > @@ -822,9 +822,8 @@
> >
> >  	usb_set_intfdata(intf, NULL);
> >
> > +	usb_kill_urb(desc->urb);
> >  	scsi_remove_host(desc->host);
> > -	usb_unlink_urb(desc->urb);
> > -	scsi_host_put(desc->host);
> >
> >  	usb_free_urb(desc->urb);
> >  	kfree(desc);
>
> I think you still need the scsi_host_put(), to account for the fact that
> scsi_host_alloc() sets the refcount to 1 initially.

Right you are. Greg, please also apply this one.
Signed-Off-By: Oliver Neukum <oliver@neukum.name>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>

drivers/usb/image/microtek.c

@@ -825,6 +825,7 @@ static void mts_usb_disconnect (struct usb_interface *intf)
 	usb_kill_urb(desc->urb);
 	scsi_remove_host(desc->host);
 
+	scsi_host_put(desc->host);
 	usb_free_urb(desc->urb);
 	kfree(desc);
 }