Commit d6ccf499 authored by Namjae Jeon's avatar Namjae Jeon Committed by Steve French

cifs: fix memory leak when password is supplied multiple times

Unlikely but possible. When password is supplied multiple times, we have
to free the previous allocation.
Signed-off-by: default avatarNamjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: default avatarAshish Sangwan <a.sangwan@samsung.com>
Signed-off-by: default avatarSteve French <smfrench@gmail.com>
parent 27b7edcf
...@@ -1600,6 +1600,7 @@ cifs_parse_mount_options(const char *mountdata, const char *devname, ...@@ -1600,6 +1600,7 @@ cifs_parse_mount_options(const char *mountdata, const char *devname,
tmp_end++; tmp_end++;
if (!(tmp_end < end && tmp_end[1] == delim)) { if (!(tmp_end < end && tmp_end[1] == delim)) {
/* No it is not. Set the password to NULL */ /* No it is not. Set the password to NULL */
kfree(vol->password);
vol->password = NULL; vol->password = NULL;
break; break;
} }
...@@ -1637,6 +1638,7 @@ cifs_parse_mount_options(const char *mountdata, const char *devname, ...@@ -1637,6 +1638,7 @@ cifs_parse_mount_options(const char *mountdata, const char *devname,
options = end; options = end;
} }
kfree(vol->password);
/* Now build new password string */ /* Now build new password string */
temp_len = strlen(value); temp_len = strlen(value);
vol->password = kzalloc(temp_len+1, GFP_KERNEL); vol->password = kzalloc(temp_len+1, GFP_KERNEL);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment