Commit d8ad2f31 authored by Jia-Ju Bai's avatar Jia-Ju Bai Committed by David S. Miller

net: adaptec: Replace mdelay() with msleep() in starfire_init_one()

starfire_init_one() is never called in atomic context.
It calls mdelay() to busily wait, which is not necessary.
mdelay() can be replaced with msleep().

This is found by a static analysis tool named DCNS written by myself.
Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 055d624f
...@@ -802,7 +802,7 @@ static int starfire_init_one(struct pci_dev *pdev, ...@@ -802,7 +802,7 @@ static int starfire_init_one(struct pci_dev *pdev,
int mii_status; int mii_status;
for (phy = 0; phy < 32 && phy_idx < PHY_CNT; phy++) { for (phy = 0; phy < 32 && phy_idx < PHY_CNT; phy++) {
mdio_write(dev, phy, MII_BMCR, BMCR_RESET); mdio_write(dev, phy, MII_BMCR, BMCR_RESET);
mdelay(100); msleep(100);
boguscnt = 1000; boguscnt = 1000;
while (--boguscnt > 0) while (--boguscnt > 0)
if ((mdio_read(dev, phy, MII_BMCR) & BMCR_RESET) == 0) if ((mdio_read(dev, phy, MII_BMCR) & BMCR_RESET) == 0)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment