Commit d99995a4 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman Committed by Dmitry Torokhov

Input: axp20x-pek - convert driver to use dev_groups

Drivers now have the option to have the driver core create and remove any
needed sysfs attribute files.  So take advantage of that and do not
register "by hand" a sysfs group of attributes.
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent cf1b2a20
...@@ -195,15 +195,12 @@ DEVICE_ATTR(startup, 0644, axp20x_show_attr_startup, axp20x_store_attr_startup); ...@@ -195,15 +195,12 @@ DEVICE_ATTR(startup, 0644, axp20x_show_attr_startup, axp20x_store_attr_startup);
DEVICE_ATTR(shutdown, 0644, axp20x_show_attr_shutdown, DEVICE_ATTR(shutdown, 0644, axp20x_show_attr_shutdown,
axp20x_store_attr_shutdown); axp20x_store_attr_shutdown);
static struct attribute *axp20x_attributes[] = { static struct attribute *axp20x_attrs[] = {
&dev_attr_startup.attr, &dev_attr_startup.attr,
&dev_attr_shutdown.attr, &dev_attr_shutdown.attr,
NULL, NULL,
}; };
ATTRIBUTE_GROUPS(axp20x);
static const struct attribute_group axp20x_attribute_group = {
.attrs = axp20x_attributes,
};
static irqreturn_t axp20x_pek_irq(int irq, void *pwr) static irqreturn_t axp20x_pek_irq(int irq, void *pwr)
{ {
...@@ -356,13 +353,6 @@ static int axp20x_pek_probe(struct platform_device *pdev) ...@@ -356,13 +353,6 @@ static int axp20x_pek_probe(struct platform_device *pdev)
axp20x_pek->info = (struct axp20x_info *)match->driver_data; axp20x_pek->info = (struct axp20x_info *)match->driver_data;
error = devm_device_add_group(&pdev->dev, &axp20x_attribute_group);
if (error) {
dev_err(&pdev->dev, "Failed to create sysfs attributes: %d\n",
error);
return error;
}
platform_set_drvdata(pdev, axp20x_pek); platform_set_drvdata(pdev, axp20x_pek);
return 0; return 0;
...@@ -411,6 +401,7 @@ static struct platform_driver axp20x_pek_driver = { ...@@ -411,6 +401,7 @@ static struct platform_driver axp20x_pek_driver = {
.driver = { .driver = {
.name = "axp20x-pek", .name = "axp20x-pek",
.pm = &axp20x_pek_pm_ops, .pm = &axp20x_pek_pm_ops,
.dev_groups = axp20x_groups,
}, },
}; };
module_platform_driver(axp20x_pek_driver); module_platform_driver(axp20x_pek_driver);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment