Commit db8ebc6d authored by Eric Dumazet's avatar Eric Dumazet Committed by Greg Kroah-Hartman

dccp/tcp: do not inherit mc_list from parent


[ Upstream commit 657831ff ]

syzkaller found a way to trigger double frees from ip_mc_drop_socket()

It turns out that leave a copy of parent mc_list at accept() time,
which is very bad.

Very similar to commit 8b485ce6 ("tcp: do not inherit
fastopen_req from parent")

Initial report from Pray3r, completed by Andrey one.
Thanks a lot to them !
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Reported-by: default avatarPray3r <pray3r.z@gmail.com>
Reported-by: default avatarAndrey Konovalov <andreyknvl@google.com>
Tested-by: default avatarAndrey Konovalov <andreyknvl@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b43ae25b
...@@ -794,6 +794,8 @@ struct sock *inet_csk_clone_lock(const struct sock *sk, ...@@ -794,6 +794,8 @@ struct sock *inet_csk_clone_lock(const struct sock *sk,
/* listeners have SOCK_RCU_FREE, not the children */ /* listeners have SOCK_RCU_FREE, not the children */
sock_reset_flag(newsk, SOCK_RCU_FREE); sock_reset_flag(newsk, SOCK_RCU_FREE);
inet_sk(newsk)->mc_list = NULL;
newsk->sk_mark = inet_rsk(req)->ir_mark; newsk->sk_mark = inet_rsk(req)->ir_mark;
atomic64_set(&newsk->sk_cookie, atomic64_set(&newsk->sk_cookie,
atomic64_read(&inet_rsk(req)->ir_cookie)); atomic64_read(&inet_rsk(req)->ir_cookie));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment