Commit dbb4a75b authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Bartlomiej Zolnierkiewicz

video: fbdev: pvr2fb: remove unnecessary comparison of unsigned integer with < 0

There is no need to compare *var->xoffset* or *var->yoffset* with < 0
because such variables are of type unsigned, making it impossible to
hold a negative value.

Fix this by removing such comparisons.

Addresses-Coverity-ID: 1451964 ("Unsigned compared against 0")
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190722203358.GA29111@embeddedor
parent 51677dfc
...@@ -458,13 +458,11 @@ static int pvr2fb_check_var(struct fb_var_screeninfo *var, struct fb_info *info) ...@@ -458,13 +458,11 @@ static int pvr2fb_check_var(struct fb_var_screeninfo *var, struct fb_info *info)
set_color_bitfields(var); set_color_bitfields(var);
if (var->vmode & FB_VMODE_YWRAP) { if (var->vmode & FB_VMODE_YWRAP) {
if (var->xoffset || var->yoffset < 0 || if (var->xoffset || var->yoffset >= var->yres_virtual) {
var->yoffset >= var->yres_virtual) {
var->xoffset = var->yoffset = 0; var->xoffset = var->yoffset = 0;
} else { } else {
if (var->xoffset > var->xres_virtual - var->xres || if (var->xoffset > var->xres_virtual - var->xres ||
var->yoffset > var->yres_virtual - var->yres || var->yoffset > var->yres_virtual - var->yres)
var->xoffset < 0 || var->yoffset < 0)
var->xoffset = var->yoffset = 0; var->xoffset = var->yoffset = 0;
} }
} else { } else {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment