Commit dc944b11 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman

USB: serial: safe_serial: fix information leak in completion handler

commit 8c76d7cd upstream.

Add missing sanity check to the bulk-in completion handler to avoid an
integer underflow that could be triggered by a malicious device.

This avoids leaking up to 56 bytes from after the URB transfer buffer to
user space.

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a062cb39
...@@ -200,6 +200,11 @@ static void safe_process_read_urb(struct urb *urb) ...@@ -200,6 +200,11 @@ static void safe_process_read_urb(struct urb *urb)
if (!safe) if (!safe)
goto out; goto out;
if (length < 2) {
dev_err(&port->dev, "malformed packet\n");
return;
}
fcs = fcs_compute10(data, length, CRC10_INITFCS); fcs = fcs_compute10(data, length, CRC10_INITFCS);
if (fcs) { if (fcs) {
dev_err(&port->dev, "%s - bad CRC %x\n", __func__, fcs); dev_err(&port->dev, "%s - bad CRC %x\n", __func__, fcs);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment