Commit e1498097 authored by Robin Murphy's avatar Robin Murphy Committed by Mark Brown

ASoC: dt-bindings: Make RK3328 codec GPIO explicit

Existing RK3328 codec drivers have overloaded the GRF phandle to assume
implicit control of the limited-function GPIO_MUTE pin, which is usually
used to enable an external audio line driver IC. Since this pin has a
proper binding of its own (see gpio/rockchip,rk3328-grf-gpio.txt), make
a GPIO explicit in the codec binding too. This will help avoid ambiguity
on boards that use that pin for some other purpose.

(and while touching the example, enforce the "don't include status" rule)
Signed-off-by: default avatarRobin Murphy <robin.murphy@arm.com>
Link: https://lore.kernel.org/r/5f7a399dea8a9dedef57f6f99f0f6ab1c1fdc56a.1581376744.git.robin.murphy@arm.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 56f1003f
...@@ -10,6 +10,11 @@ Required properties: ...@@ -10,6 +10,11 @@ Required properties:
- clock-names: should be "pclk". - clock-names: should be "pclk".
- spk-depop-time-ms: speak depop time msec. - spk-depop-time-ms: speak depop time msec.
Optional properties:
- mute-gpios: GPIO specifier for external line driver control (typically the
dedicated GPIO_MUTE pin)
Example for rk3328 internal codec: Example for rk3328 internal codec:
codec: codec@ff410000 { codec: codec@ff410000 {
...@@ -18,6 +23,6 @@ codec: codec@ff410000 { ...@@ -18,6 +23,6 @@ codec: codec@ff410000 {
rockchip,grf = <&grf>; rockchip,grf = <&grf>;
clocks = <&cru PCLK_ACODEC>; clocks = <&cru PCLK_ACODEC>;
clock-names = "pclk"; clock-names = "pclk";
mute-gpios = <&grf_gpio 0 GPIO_ACTIVE_LOW>;
spk-depop-time-ms = 100; spk-depop-time-ms = 100;
status = "disabled";
}; };
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment