Commit e45ab43b authored by YueHaibing's avatar YueHaibing Committed by Martin K. Petersen

scsi: megaraid_sas: Make some functions static

Fix sparse warnings:

drivers/scsi/megaraid/megaraid_sas_fusion.c:541:1: warning: symbol 'megasas_alloc_cmdlist_fusion' was not declared. Should it be static?
drivers/scsi/megaraid/megaraid_sas_fusion.c:580:1: warning: symbol 'megasas_alloc_request_fusion' was not declared. Should it be static?
drivers/scsi/megaraid/megaraid_sas_fusion.c:661:1: warning: symbol 'megasas_alloc_reply_fusion' was not declared. Should it be static?
drivers/scsi/megaraid/megaraid_sas_fusion.c:738:1: warning: symbol 'megasas_alloc_rdpq_fusion' was not declared. Should it be static?
drivers/scsi/megaraid/megaraid_sas_fusion.c:920:1: warning: symbol 'megasas_alloc_cmds_fusion' was not declared. Should it be static?
drivers/scsi/megaraid/megaraid_sas_fusion.c:1740:1: warning: symbol 'megasas_init_adapter_fusion' was not declared. Should it be static?
drivers/scsi/megaraid/megaraid_sas_fusion.c:1966:1: warning: symbol 'map_cmd_status' was not declared. Should it be static?
drivers/scsi/megaraid/megaraid_sas_fusion.c:2379:1: warning: symbol 'megasas_set_pd_lba' was not declared. Should it be static?
drivers/scsi/megaraid/megaraid_sas_fusion.c:2718:1: warning: symbol 'megasas_build_ldio_fusion' was not declared. Should it be static?
drivers/scsi/megaraid/megaraid_sas_fusion.c:3215:1: warning: symbol 'megasas_build_io_fusion' was not declared. Should it be static?
drivers/scsi/megaraid/megaraid_sas_fusion.c:3328:6: warning: symbol 'megasas_prepare_secondRaid1_IO' was not declared. Should it be static?
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
Acked-by: default avatarSumit Saxena <sumit.saxena@broadcom.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 3b5f307e
...@@ -537,7 +537,7 @@ static int megasas_create_sg_sense_fusion(struct megasas_instance *instance) ...@@ -537,7 +537,7 @@ static int megasas_create_sg_sense_fusion(struct megasas_instance *instance)
return 0; return 0;
} }
int static int
megasas_alloc_cmdlist_fusion(struct megasas_instance *instance) megasas_alloc_cmdlist_fusion(struct megasas_instance *instance)
{ {
u32 max_mpt_cmd, i, j; u32 max_mpt_cmd, i, j;
...@@ -576,7 +576,8 @@ megasas_alloc_cmdlist_fusion(struct megasas_instance *instance) ...@@ -576,7 +576,8 @@ megasas_alloc_cmdlist_fusion(struct megasas_instance *instance)
return 0; return 0;
} }
int
static int
megasas_alloc_request_fusion(struct megasas_instance *instance) megasas_alloc_request_fusion(struct megasas_instance *instance)
{ {
struct fusion_context *fusion; struct fusion_context *fusion;
...@@ -657,7 +658,7 @@ megasas_alloc_request_fusion(struct megasas_instance *instance) ...@@ -657,7 +658,7 @@ megasas_alloc_request_fusion(struct megasas_instance *instance)
return 0; return 0;
} }
int static int
megasas_alloc_reply_fusion(struct megasas_instance *instance) megasas_alloc_reply_fusion(struct megasas_instance *instance)
{ {
int i, count; int i, count;
...@@ -734,7 +735,7 @@ megasas_alloc_reply_fusion(struct megasas_instance *instance) ...@@ -734,7 +735,7 @@ megasas_alloc_reply_fusion(struct megasas_instance *instance)
return 0; return 0;
} }
int static int
megasas_alloc_rdpq_fusion(struct megasas_instance *instance) megasas_alloc_rdpq_fusion(struct megasas_instance *instance)
{ {
int i, j, k, msix_count; int i, j, k, msix_count;
...@@ -916,7 +917,7 @@ megasas_free_reply_fusion(struct megasas_instance *instance) { ...@@ -916,7 +917,7 @@ megasas_free_reply_fusion(struct megasas_instance *instance) {
* and is used as SMID of the cmd. * and is used as SMID of the cmd.
* SMID value range is from 1 to max_fw_cmds. * SMID value range is from 1 to max_fw_cmds.
*/ */
int static int
megasas_alloc_cmds_fusion(struct megasas_instance *instance) megasas_alloc_cmds_fusion(struct megasas_instance *instance)
{ {
int i; int i;
...@@ -1736,7 +1737,7 @@ static inline void megasas_free_ioc_init_cmd(struct megasas_instance *instance) ...@@ -1736,7 +1737,7 @@ static inline void megasas_free_ioc_init_cmd(struct megasas_instance *instance)
* *
* This is the main function for initializing firmware. * This is the main function for initializing firmware.
*/ */
u32 static u32
megasas_init_adapter_fusion(struct megasas_instance *instance) megasas_init_adapter_fusion(struct megasas_instance *instance)
{ {
struct fusion_context *fusion; struct fusion_context *fusion;
...@@ -1962,7 +1963,7 @@ megasas_fusion_stop_watchdog(struct megasas_instance *instance) ...@@ -1962,7 +1963,7 @@ megasas_fusion_stop_watchdog(struct megasas_instance *instance)
* @ext_status : ext status of cmd returned by FW * @ext_status : ext status of cmd returned by FW
*/ */
void static void
map_cmd_status(struct fusion_context *fusion, map_cmd_status(struct fusion_context *fusion,
struct scsi_cmnd *scmd, u8 status, u8 ext_status, struct scsi_cmnd *scmd, u8 status, u8 ext_status,
u32 data_length, u8 *sense) u32 data_length, u8 *sense)
...@@ -2375,7 +2376,7 @@ int megasas_make_sgl(struct megasas_instance *instance, struct scsi_cmnd *scp, ...@@ -2375,7 +2376,7 @@ int megasas_make_sgl(struct megasas_instance *instance, struct scsi_cmnd *scp,
* *
* Used to set the PD LBA in CDB for FP IOs * Used to set the PD LBA in CDB for FP IOs
*/ */
void static void
megasas_set_pd_lba(struct MPI2_RAID_SCSI_IO_REQUEST *io_request, u8 cdb_len, megasas_set_pd_lba(struct MPI2_RAID_SCSI_IO_REQUEST *io_request, u8 cdb_len,
struct IO_REQUEST_INFO *io_info, struct scsi_cmnd *scp, struct IO_REQUEST_INFO *io_info, struct scsi_cmnd *scp,
struct MR_DRV_RAID_MAP_ALL *local_map_ptr, u32 ref_tag) struct MR_DRV_RAID_MAP_ALL *local_map_ptr, u32 ref_tag)
...@@ -2714,7 +2715,7 @@ megasas_set_raidflag_cpu_affinity(struct fusion_context *fusion, ...@@ -2714,7 +2715,7 @@ megasas_set_raidflag_cpu_affinity(struct fusion_context *fusion,
* Prepares the io_request and chain elements (sg_frame) for IO * Prepares the io_request and chain elements (sg_frame) for IO
* The IO can be for PD (Fast Path) or LD * The IO can be for PD (Fast Path) or LD
*/ */
void static void
megasas_build_ldio_fusion(struct megasas_instance *instance, megasas_build_ldio_fusion(struct megasas_instance *instance,
struct scsi_cmnd *scp, struct scsi_cmnd *scp,
struct megasas_cmd_fusion *cmd) struct megasas_cmd_fusion *cmd)
...@@ -3211,7 +3212,7 @@ megasas_build_syspd_fusion(struct megasas_instance *instance, ...@@ -3211,7 +3212,7 @@ megasas_build_syspd_fusion(struct megasas_instance *instance,
* Invokes helper functions to prepare request frames * Invokes helper functions to prepare request frames
* and sets flags appropriate for IO/Non-IO cmd * and sets flags appropriate for IO/Non-IO cmd
*/ */
int static int
megasas_build_io_fusion(struct megasas_instance *instance, megasas_build_io_fusion(struct megasas_instance *instance,
struct scsi_cmnd *scp, struct scsi_cmnd *scp,
struct megasas_cmd_fusion *cmd) struct megasas_cmd_fusion *cmd)
...@@ -3325,9 +3326,9 @@ megasas_get_request_descriptor(struct megasas_instance *instance, u16 index) ...@@ -3325,9 +3326,9 @@ megasas_get_request_descriptor(struct megasas_instance *instance, u16 index)
/* megasas_prepate_secondRaid1_IO /* megasas_prepate_secondRaid1_IO
* It prepares the raid 1 second IO * It prepares the raid 1 second IO
*/ */
void megasas_prepare_secondRaid1_IO(struct megasas_instance *instance, static void megasas_prepare_secondRaid1_IO(struct megasas_instance *instance,
struct megasas_cmd_fusion *cmd, struct megasas_cmd_fusion *cmd,
struct megasas_cmd_fusion *r1_cmd) struct megasas_cmd_fusion *r1_cmd)
{ {
union MEGASAS_REQUEST_DESCRIPTOR_UNION *req_desc, *req_desc2 = NULL; union MEGASAS_REQUEST_DESCRIPTOR_UNION *req_desc, *req_desc2 = NULL;
struct fusion_context *fusion; struct fusion_context *fusion;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment